averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SourceKit/CursorInfo] Still print implicit decls in cursorinfo to handle compiler synthesized decls

Browse Source 
We weren't printing memberwise inits, shorthand arguments (e.g. $0, $1), and
other implicit decls, so cursor info would give empty annotated decl and fully
annotated decl fields for them.

Resolves rdar://problem/58929991
This commit is contained in:
Nathan Hawes
2020-06-26 11:12:10 -07:00
parent 01e6cb35a9
commit a1f0155525
2 changed files with 33 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/SourceKit/CursorInfo/cursor_info_synthesized_refs.swift Normal file
View File

@@ -0,0 +1,18 @@
struct Foo {
let x: Int
let y: String
func perform(_ action: (Int, Int) -> ()) {}
}
func test() {
let x = Foo.init(x: 2, y: "hello")
x.perform {
print($0 + $1)
}
}
// RUN: %sourcekitd-test -req=cursor -pos=8:17 %s -- %s | %FileCheck -check-prefix=CHECK1 %s
// CHECK1: <Declaration>init(x: <Type usr="s:Si">Int</Type>, y: <Type usr="s:SS">String</Type>)</Declaration>
// RUN: %sourcekitd-test -req=cursor -pos=10:15 %s -- %s | %FileCheck -check-prefix=CHECK2 %s
// CHECK2: <Declaration>let $0: <Type usr="s:Si">Int</Type></Declaration>

31
tools/SourceKit/lib/SwiftLang/SwiftSourceDocInfo.cpp
View File

@@ -415,14 +415,13 @@ static void printAnnotatedDeclaration(const ValueDecl *VD,
while (VD->isImplicit() && VD->getOverriddenDecl()) while (VD->isImplicit() && VD->getOverriddenDecl())
VD = VD->getOverriddenDecl(); VD = VD->getOverriddenDecl();
// If this is a property wrapper backing property (_foo) or projected value // VD may be a compiler synthesized member, constructor, or shorthand argument
// ($foo) and the wrapped property is not implicit, still print it. // so always print it even if it's implicit.
if (auto *VarD = dyn_cast<VarDecl>(VD)) { //
if (auto *Wrapped = VarD->getOriginalWrappedProperty()) { // FIXME: Update PrintOptions::printQuickHelpDeclaration to print implicit
if (!Wrapped->isImplicit()) // decls by default. That causes issues due to newlines being printed before
PO.TreatAsExplicitDeclList.push_back(VD); // implicit OpaqueTypeDecls at time of writing.
} PO.TreatAsExplicitDeclList.push_back(VD);
}
// Wrap this up in XML, as that's what we'll use for documentation comments. // Wrap this up in XML, as that's what we'll use for documentation comments.
OS<<"<Declaration>"; OS<<"<Declaration>";
@@ -446,14 +445,14 @@ void SwiftLangSupport::printFullyAnnotatedDeclaration(const ValueDecl *VD,
while (VD->isImplicit() && VD->getOverriddenDecl()) while (VD->isImplicit() && VD->getOverriddenDecl())
VD = VD->getOverriddenDecl(); VD = VD->getOverriddenDecl();
// If this is a property wrapper backing property (_foo) or projected value // VD may be a compiler synthesized member, constructor, or shorthand argument
// ($foo) and the wrapped property is not implicit, still print it. // so always print it even if it's implicit.
if (auto *VarD = dyn_cast<VarDecl>(VD)) { //
if (auto *Wrapped = VarD->getOriginalWrappedProperty()) { // FIXME: Update PrintOptions::printQuickHelpDeclaration to print implicit
if (!Wrapped->isImplicit()) // decls by default. That causes issues due to newlines being printed before
PO.TreatAsExplicitDeclList.push_back(VD); // implicit OpaqueTypeDecls at time of writing.
} PO.TreatAsExplicitDeclList.push_back(VD);
}
VD->print(Printer, PO); VD->print(Printer, PO);
} }