averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[region-isolation] Ensure that we error if we access a Sendable field of a non-Sendable typed var and the var is captured in a closure

Browse Source 
If the var is captured in a closure before it is transferred, it is not safe to
access the Sendable field since we may race on accessing the field with an
assignment to the field in another concurrency domain.

rdar://115124361
This commit is contained in:
Michael Gottesman
2023-11-30 12:27:58 -08:00
parent 556c503685
commit a2604dcafa
5 changed files with 847 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
unittests/SILOptimizer/PartitionUtilsTest.cpp
View File

@@ -548,14 +548,13 @@ TEST(PartitionUtilsTest, TestConsumeAndRequire) {
// expected: p: ({0 1 2 6 7 10} (3 4 5) (8 9) (Element(11)))
auto never_called = [](const PartitionOp &, unsigned, Operand *) {
auto never_called = [](const PartitionOp &, unsigned, TransferringOperand) {
EXPECT_TRUE(false);
};
int times_called = 0;
auto increment_times_called = [&](const PartitionOp &, unsigned, Operand *) {
times_called++;
};
auto increment_times_called = [&](const PartitionOp &, unsigned,
TransferringOperand) { times_called++; };
{
PartitionOpEvaluator eval(p);
@@ -623,18 +622,16 @@ TEST(PartitionUtilsTest, TestCopyConstructor) {
{
bool failure = false;
PartitionOpEvaluator eval(p1);
eval.failureCallback = [&](const PartitionOp &, unsigned, Operand *) {
failure = true;
};
eval.failureCallback = [&](const PartitionOp &, unsigned,
TransferringOperand) { failure = true; };
eval.apply(PartitionOp::Require(Element(0)));
EXPECT_TRUE(failure);
}
{
PartitionOpEvaluator eval(p2);
eval.failureCallback = [](const PartitionOp &, unsigned, Operand *) {
EXPECT_TRUE(false);
};
eval.failureCallback = [](const PartitionOp &, unsigned,
TransferringOperand) { EXPECT_TRUE(false); };
eval.apply(PartitionOp::Require(Element(0)));
}
}
@@ -642,9 +639,8 @@ TEST(PartitionUtilsTest, TestCopyConstructor) {
TEST(PartitionUtilsTest, TestUndoTransfer) {
Partition p;
PartitionOpEvaluator eval(p);
eval.failureCallback = [&](const PartitionOp &, unsigned, Operand *) {
EXPECT_TRUE(false);
};
eval.failureCallback = [&](const PartitionOp &, unsigned,
TransferringOperand) { EXPECT_TRUE(false); };
// Shouldn't error on this.
eval.apply({PartitionOp::AssignFresh(Element(0)),