averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

OSSA ownership optimization RAUW utility fixes.

Browse Source 
Verify that the OwnershipRAUWUtility always preserves the original
borrow scope by exhaustively switching over OperandOwnership.

And related cleanup.
This commit is contained in:
Andrew Trick
2021-01-22 20:19:30 -08:00
parent 1f1123f6c0
commit a2fac95f9f
7 changed files with 136 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/SIL/Utils/OwnershipUtils.cpp
View File

@@ -520,7 +520,7 @@ bool BorrowedValue::visitInteriorPointerOperands(
// InteriorPointerOperand
//===----------------------------------------------------------------------===//
bool InteriorPointerOperand::getImplicitUsesForAddress(
bool InteriorPointerOperand::findTransitiveUsesForAddress(
SILValue projectedAddress, SmallVectorImpl<Operand *> &foundUses,
std::function<void(Operand *)> *onError) {
SmallVector<Operand *, 8> worklist(projectedAddress->getUses());
@@ -882,12 +882,12 @@ OwnedValueIntroducer swift::getSingleOwnedValueIntroducer(SILValue inputValue) {
// Forwarding Operand
//===----------------------------------------------------------------------===//
ForwardingOperand ForwardingOperand::get(Operand *use) {
ForwardingOperand::ForwardingOperand(Operand *use) {
if (use->isTypeDependent())
return nullptr;
return;
if (!OwnershipForwardingMixin::isa(use->getUser())) {
return nullptr;
return;
}
#ifndef NDEBUG
switch (use->getOperandOwnership()) {
@@ -909,7 +909,7 @@ ForwardingOperand ForwardingOperand::get(Operand *use) {
llvm_unreachable("this isn't the operand being forwarding!");
}
#endif
return {use};
this->use = use;
}
ValueOwnershipKind ForwardingOperand::getOwnershipKind() const {
@@ -1008,7 +1008,7 @@ void ForwardingOperand::setOwnershipKind(ValueOwnershipKind newKind) const {
return;
}
llvm_unreachable("Out of sync with ForwardingOperand::get?!");
llvm_unreachable("Out of sync with OperandOwnership");
}
void ForwardingOperand::replaceOwnershipKind(ValueOwnershipKind oldKind,
@@ -1075,7 +1075,7 @@ void ForwardingOperand::replaceOwnershipKind(ValueOwnershipKind oldKind,
return;
}
llvm_unreachable("Missing Case! Out of sync with ForwardingOperand::get?!");
llvm_unreachable("Missing Case! Out of sync with OperandOwnership");
}
SILValue ForwardingOperand::getSingleForwardedValue() const {