averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[gardening] Use Collection.isEmpty over Collection.count

Browse Source
This commit is contained in:
Sho Ikeda
2019-05-26 09:35:20 +09:00
parent b088acb66e
commit a35c9f0c60
11 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
stdlib/public/core/StringUTF8Validation.swift
View File

@@ -154,7 +154,7 @@ internal func validateUTF8(_ buf: UnsafeBufferPointer<UInt8>) -> UTF8ValidationR
}
internal func repairUTF8(_ input: UnsafeBufferPointer<UInt8>, firstKnownBrokenRange: Range<Int>) -> String {
_internalInvariant(input.count > 0, "empty input doesn't need to be repaired")
_internalInvariant(!input.isEmpty, "empty input doesn't need to be repaired")
_internalInvariant(firstKnownBrokenRange.clamped(to: input.indices) == firstKnownBrokenRange)
// During this process, `remainingInput` contains the remaining bytes to process. It's split into three
// non-overlapping sub-regions:
@@ -176,8 +176,8 @@ internal func repairUTF8(_ input: UnsafeBufferPointer<UInt8>, firstKnownBrokenRa
var brokenRange: Range<Int> = firstKnownBrokenRange
var remainingInput = input
repeat {
_internalInvariant(brokenRange.count > 0, "broken range empty")
_internalInvariant(remainingInput.count > 0, "empty remaining input doesn't need to be repaired")
_internalInvariant(!brokenRange.isEmpty, "broken range empty")
_internalInvariant(!remainingInput.isEmpty, "empty remaining input doesn't need to be repaired")
let goodChunk = remainingInput[..<brokenRange.startIndex]
// very likely this capacity reservation does not actually do anything because we reserved space for the entire
@@ -199,6 +199,6 @@ internal func repairUTF8(_ input: UnsafeBufferPointer<UInt8>, firstKnownBrokenRa
case .error(let newBrokenRange):
brokenRange = newBrokenRange
}
} while remainingInput.count > 0
} while !remainingInput.isEmpty
return String(result)
}