averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

IRGen: Rename internal 'POD' references to 'TriviallyDestroyable'.

Browse Source 
Noncopyable types aren't really "POD", but the bit is still useful to track
whether a noncopyable type has a no-op destroy operation, so rename the
existing bit to be more specific within IRGen's implementation.

Don't rename it in the runtime or Builtin names yet, since doing so will
require a naming transition for compatibility.
This commit is contained in:
Joe Groff
2023-02-23 08:28:18 -08:00
parent f20eaac5be
commit a572c3f491
31 changed files with 292 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/IRGen/GenStruct.cpp
View File

@@ -369,7 +369,7 @@ namespace {
const clang::RecordDecl *clangDecl)
: StructTypeInfoBase(StructTypeInfoKind::LoadableClangRecordTypeInfo,
fields, explosionSize, storageType, size,
std::move(spareBits), align, IsPOD, IsFixedSize),
std::move(spareBits), align, IsTriviallyDestroyable, IsFixedSize),
ClangDecl(clangDecl) {}
TypeLayoutEntry
@@ -468,7 +468,7 @@ namespace {
// with user-defined special member functions.
SpareBitVector(llvm::Optional<APInt>{
llvm::APInt(size.getValueInBits(), 0)}),
align, IsNotPOD, IsNotBitwiseTakable, IsFixedSize),
align, IsNotTriviallyDestroyable, IsNotBitwiseTakable, IsFixedSize),
clangDecl(clangDecl) {
(void)clangDecl;
}
@@ -622,7 +622,7 @@ namespace {
// with user-defined special member functions.
SpareBitVector(llvm::Optional<APInt>{
llvm::APInt(size.getValueInBits(), 0)}),
align, IsNotPOD, IsNotBitwiseTakable, IsFixedSize),
align, IsNotTriviallyDestroyable, IsNotBitwiseTakable, IsFixedSize),
ClangDecl(clangDecl) {
(void)ClangDecl;
}
@@ -805,12 +805,12 @@ namespace {
unsigned explosionSize,
llvm::Type *storageType, Size size,
SpareBitVector &&spareBits,
Alignment align, IsPOD_t isPOD,
Alignment align, IsTriviallyDestroyable_t isTriviallyDestroyable,
IsFixedSize_t alwaysFixedSize)
: StructTypeInfoBase(StructTypeInfoKind::LoadableStructTypeInfo,
fields, explosionSize,
storageType, size, std::move(spareBits),
align, isPOD, alwaysFixedSize)
align, isTriviallyDestroyable, alwaysFixedSize)
{}
void addToAggLowering(IRGenModule &IGM, SwiftAggLowering &lowering,
@@ -892,11 +892,11 @@ namespace {
// FIXME: Spare bits between struct members.
FixedStructTypeInfo(ArrayRef<StructFieldInfo> fields, llvm::Type *T,
Size size, SpareBitVector &&spareBits,
Alignment align, IsPOD_t isPOD, IsBitwiseTakable_t isBT,
Alignment align, IsTriviallyDestroyable_t isTriviallyDestroyable, IsBitwiseTakable_t isBT,
IsFixedSize_t alwaysFixedSize)
: StructTypeInfoBase(StructTypeInfoKind::FixedStructTypeInfo,
fields, T, size, std::move(spareBits), align,
isPOD, isBT, alwaysFixedSize)
isTriviallyDestroyable, isBT, alwaysFixedSize)
{}
TypeLayoutEntry
@@ -984,11 +984,11 @@ namespace {
FieldsAreABIAccessible_t fieldsAccessible,
llvm::Type *T,
Alignment align,
IsPOD_t isPOD, IsBitwiseTakable_t isBT,
IsTriviallyDestroyable_t isTriviallyDestroyable, IsBitwiseTakable_t isBT,
IsABIAccessible_t structAccessible)
: StructTypeInfoBase(StructTypeInfoKind::NonFixedStructTypeInfo,
fields, fieldsAccessible,
T, align, isPOD, isBT, structAccessible) {
T, align, isTriviallyDestroyable, isBT, structAccessible) {
}
TypeLayoutEntry
@@ -1115,7 +1115,7 @@ namespace {
layout.getSize(),
std::move(layout.getSpareBits()),
layout.getAlignment(),
layout.isPOD(),
layout.isTriviallyDestroyable(),
layout.isAlwaysFixedSize());
}
@@ -1125,7 +1125,7 @@ namespace {
layout.getSize(),
std::move(layout.getSpareBits()),
layout.getAlignment(),
layout.isPOD(),
layout.isTriviallyDestroyable(),
layout.isBitwiseTakable(),
layout.isAlwaysFixedSize());
}
@@ -1138,7 +1138,7 @@ namespace {
return NonFixedStructTypeInfo::create(fields, fieldsAccessible,
layout.getType(),
layout.getAlignment(),
layout.isPOD(),
layout.isTriviallyDestroyable(),
layout.isBitwiseTakable(),
structAccessible);
}
@@ -1388,9 +1388,9 @@ private:
auto isEmpty = fieldType.isKnownEmpty(ResilienceExpansion::Maximal);
if (isEmpty)
layout.completeEmptyTailAllocatedCType(
fieldType.isPOD(ResilienceExpansion::Maximal), NextOffset);
fieldType.isTriviallyDestroyable(ResilienceExpansion::Maximal), NextOffset);
else
layout.completeFixed(fieldType.isPOD(ResilienceExpansion::Maximal),
layout.completeFixed(fieldType.isTriviallyDestroyable(ResilienceExpansion::Maximal),
NextOffset, LLVMFields.size());
if (isLoadableField)