averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use Swift Equatable and Hashable conformances from ObjC

Browse Source 
If a Swift type implements Equatable and/or Hashable and
we then pass that object into ObjC, we want ObjC
`isEqual:` and `hashValue` to use that.  This allows
ObjC code to build ObjC collections of Swift objects.

* Support for Hashable struct/enum types was implemented in #4124
* Support for Equatable struct/enum types was implemented in #68720
* This implements support for Hashable and Equatable _class_ types

Caveats:
1. This does a lot of dynamic lookup work for each operation, so is
   inherently rather slow.  Unlike the struct/enum case, there is no convenient
   place to cache the conformance information, so it's not clear that there is a
   viable way to make it significantly faster.
2. This is a behavioral change to low-level support code.  There is a
   risk of breaking code that may be relying on the old behavior.
This commit is contained in:
Tim Kientzle
2023-10-27 12:01:44 -07:00
parent e8761b89ff
commit a840c69392
3 changed files with 91 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/stdlib/SwiftObjectNSObject.swift
View File

@@ -39,8 +39,24 @@ class D : C {
@objc override class func cClassOverride() -> Int { return 8 }
}
class E : Equatable {
var i : Int
static func ==(lhs: E, rhs: E) -> Bool { lhs.i == rhs.i }
init(i: Int) { self.i = i }
}
class H : Hashable {
var i : Int
static func ==(lhs: H, rhs: H) -> Bool { lhs.i == rhs.i }
func hash(into hasher: inout Hasher) { hasher.combine(i + 17) }
init(i: Int) { self.i = i }
}
@_silgen_name("TestSwiftObjectNSObject")
func TestSwiftObjectNSObject(_ c: C, _ d: D)
func TestSwiftObjectNSObject(
_ c: C, _ d: D,
_ e1a: E, _ e1b: E, _ e2: E,
_ h1a: H, _ h1b: H, _ h2: H, _ hash1: UInt, _ hash2: UInt)
// This check is for NSLog() output from TestSwiftObjectNSObject().
// CHECK: c ##SwiftObjectNSObject.C##
@@ -50,7 +66,9 @@ func TestSwiftObjectNSObject(_ c: C, _ d: D)
// Temporarily disable this test on older OSes until we have time to
// look into why it's failing there. rdar://problem/47870743
if #available(OSX 10.12, iOS 10.0, *) {
TestSwiftObjectNSObject(C(), D())
TestSwiftObjectNSObject(C(), D(),
E(i:1), E(i:1), E(i:2),
H(i:1), H(i:1), H(i:2), UInt(H(i:1).hashValue), UInt(H(i:2).hashValue))
// does not return
} else {
// Horrible hack to satisfy FileCheck