averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Simplify some of the logic around metatypes in the devirtualizer.

Browse Source 
NFC.

Swift SVN r25977
This commit is contained in:
Mark Lacey
2015-03-11 08:43:40 +00:00
parent fbc7b76614
commit a9f29281f7
1 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/SILPasses/Devirtualizer.cpp
View File

@@ -341,28 +341,29 @@ static bool insertInlineCaches(ApplyInst *AI, ClassHierarchyAnalysis *CHA) {
return false;
// Strip any upcasts off of our 'self' value, potentially leaving us
// with a value whose type is closer (in the class hierarchy) to the
// actual dynamic type.
// with a class value or class metatype value whose type is closer
// (in the class hierarchy) to the actual dynamic type.
auto SubTypeValue = CMI->getOperand().stripUpCasts();
SILType SubType = SubTypeValue.getType();
auto &M = AI->getModule();
// Bail if any generic types parameters of the class instance type are
// unbound.
// We cannot devirtualize unbound generic calls yet.
if (isClassWithUnboundGenericParameters(SubType, AI->getModule()))
if (isClassWithUnboundGenericParameters(SubType, M))
return false;
ClassDecl *CD = SubType.getClassOrBoundGenericClass();
// We're operating on either a class-typed value or class
// metatype-typed value. In the latter case we need to get the
// instance type in order to obtain the ClassDecl, which is used to
// determine what kind of speculative devirtualizaton to do.
SILType ClassTy = SubType;
if (SubType.is<MetatypeType>())
ClassTy = SubType.getMetatypeInstanceType(M);
if (auto *VMTI = dyn_cast<ValueMetatypeInst>(SubTypeValue)) {
CanType InstTy = VMTI->getType().castTo<MetatypeType>().getInstanceType();
CD = InstTy.getClassOrBoundGenericClass();
assert(CD && "Non-class type for instance type of class metatype?!");
}
// Check if it is legal to insert inline caches.
if (!CD)
return false;
ClassDecl *CD = ClassTy.getClassOrBoundGenericClass();
assert(CD && "Expected class decl for class type!");
if (!CHA->hasKnownDirectSubclasses(CD)) {
// If there is only one possible alternative for this method,