Merge pull request #9001 from practicalswift/gardening-20170425

[gardening] Unused variables. Unused diagnostics. Namespace comments. Typos.

include/swift/ABI/System.h

@@ -59,7 +59,7 @@
 // Weak references use a marker to tell when they are controlled by
 // the ObjC runtime and when they are controlled by the Swift runtime.
 // Non-ObjC platforms don't use this marker.
-#define SWIFT_ABI_DEFAULT_OBJC_WEAK_REFERENCE_MARKER_MASK  0
+#define SWIFT_ABI_DEFAULT_OBJC_WEAK_REFERENCE_MARKER_MASK 0
 #define SWIFT_ABI_DEFAULT_OBJC_WEAK_REFERENCE_MARKER_VALUE 0
 
 /*********************************** i386 *************************************/

include/swift/AST/DiagnosticsParse.def

@@ -550,8 +550,6 @@ ERROR(sil_objc_with_tail_elements,none,
       "alloc_ref [objc] cannot have tail allocated elements", ())
 ERROR(found_unqualified_instruction_in_qualified_function,none,
       "found unqualified instruction in qualified function '%0'", (StringRef))
-ERROR(sil_unknown_access_kind_or_enforcement,none,
-      "expected access kind or enforcement", ())
 ERROR(sil_expected_access_kind,none,
       "%0 instruction must have explicit access kind", (StringRef))
 ERROR(sil_expected_access_enforcement,none,
@@ -1180,8 +1178,6 @@ ERROR(expr_keypath_expected_property_or_type,PointsToFirstBadToken,
       "expected property or type name within '#keyPath(...)'", ())
 ERROR(expr_keypath_expected_rparen,PointsToFirstBadToken,
       "expected ')' to complete '#keyPath' expression", ())
-ERROR(expr_keypath_compound_name,none,
-      "cannot use compound name %0 in '#keyPath' expression", (DeclName))
 
 // Selector expressions.
 ERROR(expr_selector_expected_lparen,PointsToFirstBadToken,

include/swift/Migrator/SyntacticMigratorPass.h

@@ -36,7 +36,7 @@ public:
   const clang::edit::Commit &getEdits() const;
 };
 
-} // end namespae migrator
+} // end namespace migrator
 } // end namespace swift
 
 #endif // SWIFT_MIGRATOR_SYNTACTICMIGRATORPASS_H

include/swift/Runtime/Config.h

@@ -134,9 +134,9 @@
 #define SWIFT_LLVM_CC_RegisterPreservingCC llvm::CallingConv::PreserveMost
 
 #if SWIFT_USE_SWIFTCALL
-#define SWIFT_LLVM_CC_SwiftCC  llvm::CallingConv::Swift
+#define SWIFT_LLVM_CC_SwiftCC llvm::CallingConv::Swift
 #else
-#define SWIFT_LLVM_CC_SwiftCC  llvm::CallingConv::C
+#define SWIFT_LLVM_CC_SwiftCC llvm::CallingConv::C
 #endif
 
 // If defined, it indicates that runtime function wrappers

include/swift/SIL/SILInstruction.h

@@ -4994,7 +4994,7 @@ class EndLifetimeInst
 
 /// An unsafe conversion in between ownership kinds.
 ///
-/// This is used today in destructors where due to objective-c legacy
+/// This is used today in destructors where due to Objective-C legacy
 /// constraints, we need to be able to convert a guaranteed parameter to an owned
 /// parameter.
 class UncheckedOwnershipConversionInst