averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve diagnostic in cases like 'if let foo.bar'

Browse Source
This commit is contained in:
Cal Stephens
2022-03-13 12:20:01 -07:00
parent 38e2b70d5d
commit ac7529f5bd
3 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Parse/ParseStmt.cpp
View File

@@ -1635,6 +1635,13 @@ Parser::parseStmtConditionElement(SmallVectorImpl<StmtConditionElement> &result,
declRefExpr->setImplicit();
Init = makeParserResult(declRefExpr);
} else if (!ThePattern.isNull()) {
// If the pattern is present but isn't an identifier, the user wrote
// something invalid like `let foo.bar`. Emit a special diagnostic for this,
// with a fix-it prepending "<#identifier#> = "
auto diagLoc = ThePattern.get()->getSemanticsProvidingPattern()->getStartLoc();
diagnose(diagLoc, diag::conditional_var_valid_identifiers_only)
.fixItInsert(diagLoc, "<#identifier#> = ");
} else {
diagnose(Tok, diag::conditional_var_initializer_required);
}