averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[swift-api-digester] Detect static decls become non-static and also the other way around.

Browse Source
This commit is contained in:
Xi Ge
2016-10-24 17:13:34 -07:00
committed by GitHub
parent 05f45945ec
commit ad3a9f276b
6 changed files with 280 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -841,7 +841,13 @@ bool SDKNode::operator==(const SDKNode &Other) const {
}
case SDKNodeKind::TypeDecl:
case SDKNodeKind::Var:
case SDKNodeKind::TypeAlias:
case SDKNodeKind::TypeAlias: {
auto Left = this->getAs<SDKNodeDecl>();
auto Right = (&Other)->getAs<SDKNodeDecl>();
if (Left->isStatic() ^ Right->isStatic())
return false;
SWIFT_FALLTHROUGH;
}
case SDKNodeKind::Root:
case SDKNodeKind::Nil: {
if (getPrintedName() == Other.getPrintedName() &&
@@ -1876,7 +1882,7 @@ public:
}
};
void detectThrowing(NodePtr L, NodePtr R) {
static void detectThrowing(NodePtr L, NodePtr R) {
assert(L->getKind() == R->getKind());
if (auto LF = dyn_cast<SDKNodeAbstractFunc>(L)) {
auto RF = R->getAs<SDKNodeAbstractFunc>();
@@ -1886,7 +1892,7 @@ void detectThrowing(NodePtr L, NodePtr R) {
}
}
void detectMutating(NodePtr L, NodePtr R) {
static void detectMutating(NodePtr L, NodePtr R) {
assert(L->getKind() == R->getKind());
if (auto LF = dyn_cast<SDKNodeAbstractFunc>(L)) {
auto RF = R->getAs<SDKNodeAbstractFunc>();
@@ -1907,6 +1913,15 @@ static void detectRename(NodePtr L, NodePtr R) {
}
}
static void detectStaticUpdate(NodePtr L, NodePtr R) {
assert(L->getKind() == R->getKind());
if (auto LD = dyn_cast<SDKNodeDecl>(L)) {
if (LD->isStatic() ^ R->getAs<SDKNodeDecl>()->isStatic()) {
L->annotate(NodeAnnotation::StaticChange);
}
}
}
// This is first pass on two given SDKNode trees. This pass removes the common part
// of two versions of SDK, leaving only the changed part.
class PrunePass : public MatchedNodeListener, public SDKTreeDiffPass {
@@ -1960,6 +1975,7 @@ public:
detectRename(Left, Right);
detectThrowing(Left, Right);
detectMutating(Left, Right);
detectStaticUpdate(Left, Right);
switch(Kind) {
case SDKNodeKind::Root:
@@ -2846,6 +2862,11 @@ void DiagnosisEmitter::visitDecl(SDKNodeDecl *Node) {
Node->getFullyQualifiedName(),
InsertToBuffer("throwing"));
}
if (Node->isAnnotatedAs(NodeAnnotation::StaticChange)) {
AttrChangedDecls.Diags.emplace_back(Node->getDeclKind(),
Node->getFullyQualifiedName(),
InsertToBuffer(Node->isStatic() ? "not static" : "static"));
}
}
void DiagnosisEmitter::visitType(SDKNodeType *Node) {
auto *Parent = Node->getParent()->getAs<SDKNodeDecl>();