averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

api-digester: diagnose adding conformances to existing protocols. rdar://48131686

Browse Source
This commit is contained in:
Xi Ge
2019-05-14 15:40:04 -07:00
parent f7881eed66
commit ae16a74af9
4 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -951,6 +951,8 @@ class PrunePass : public MatchedNodeListener, public SDKTreeDiffPass {
SDKContext &Ctx;
UpdatedNodesMap &UpdateMap;
llvm::StringSet<> ProtocolReqWhitelist;
SDKNodeRoot *LeftRoot;
SDKNodeRoot *RightRoot;
static void printSpaces(llvm::raw_ostream &OS, SDKNode *N) {
assert(N);
@@ -1028,6 +1030,12 @@ public:
auto *TD = Conf->getNominalTypeDecl();
if (TD->isProtocol()) {
TD->emitDiag(diag::conformance_added, Conf->getName());
} else {
// Adding conformance to an existing type can be ABI breaking.
if (Ctx.checkingABI() &&
!LeftRoot->getDescendantsByUsr(Conf->getUsr()).empty()) {
TD->emitDiag(diag::existing_conformance_added, Conf->getName());
}
}
}
@@ -1128,6 +1136,8 @@ public:
}
void pass(NodePtr Left, NodePtr Right) override {
LeftRoot = Left->getAs<SDKNodeRoot>();
RightRoot = Right->getAs<SDKNodeRoot>();
foundMatch(Left, Right, NodeMatchReason::Root);
}
};