averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[cast-opt] Extract out the retrieval of the ObjC -> Swift bridging functions into a helper function.

Browse Source 
NFC. Extracted using Xcode.
This commit is contained in:
Michael Gottesman
2019-03-04 23:07:54 -08:00
parent 0d9b1963c7
commit aefbc490d6
1 changed files with 26 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
lib/SILOptimizer/Utils/CastOptimizer.cpp
View File

@@ -45,6 +45,27 @@
using namespace swift; using namespace swift;
static SILFunction *
getObjCToSwiftBridgingFunction(SILOptFunctionBuilder &funcBuilder,
SILDynamicCastInst dynamicCast) {
// inline constructor.
auto *bridgeFuncDecl = [&]() -> FuncDecl * {
auto &astContext = dynamicCast.getModule().getASTContext();
if (dynamicCast.isConditional()) {
return astContext.getConditionallyBridgeFromObjectiveCBridgeable();
}
return astContext.getForceBridgeFromObjectiveCBridgeable();
}();
assert(bridgeFuncDecl && "Bridging function doesn't exist?!");
SILDeclRef funcDeclRef(bridgeFuncDecl, SILDeclRef::Kind::Func);
// Lookup a function from the stdlib.
return funcBuilder.getOrCreateFunction(dynamicCast.getLocation(), funcDeclRef,
ForDefinition_t::NotForDefinition);
}
/// Create a call of _forceBridgeFromObjectiveC_bridgeable or /// Create a call of _forceBridgeFromObjectiveC_bridgeable or
/// _conditionallyBridgeFromObjectiveC_bridgeable which converts an ObjC /// _conditionallyBridgeFromObjectiveC_bridgeable which converts an ObjC
/// instance into a corresponding Swift type, conforming to /// instance into a corresponding Swift type, conforming to
@@ -67,20 +88,9 @@ CastOptimizer::optimizeBridgedObjCToSwiftCast(SILDynamicCastInst dynamicCast) {
// The conformance to _BridgedToObjectiveC is statically known. // The conformance to _BridgedToObjectiveC is statically known.
// Retrieve the bridging operation to be used if a static conformance // Retrieve the bridging operation to be used if a static conformance
// to _BridgedToObjectiveC can be proven. // to _BridgedToObjectiveC can be proven.
FuncDecl *BridgeFuncDecl = SILFunction *bridgingFunc =
isConditional getObjCToSwiftBridgingFunction(FunctionBuilder, dynamicCast);
? M.getASTContext().getConditionallyBridgeFromObjectiveCBridgeable() if (!bridgingFunc)
: M.getASTContext().getForceBridgeFromObjectiveCBridgeable();
assert(BridgeFuncDecl && "_forceBridgeFromObjectiveC should exist");
SILDeclRef FuncDeclRef(BridgeFuncDecl, SILDeclRef::Kind::Func);
// Lookup a function from the stdlib.
SILFunction *BridgedFunc = FunctionBuilder.getOrCreateFunction(
Loc, FuncDeclRef, ForDefinition_t::NotForDefinition);
if (!BridgedFunc)
return nullptr; return nullptr;
CanType CanBridgedTy = BridgedTargetTy->getCanonicalType(); CanType CanBridgedTy = BridgedTargetTy->getCanonicalType();
@@ -170,9 +180,9 @@ CastOptimizer::optimizeBridgedObjCToSwiftCast(SILDynamicCastInst dynamicCast) {
M.getASTContext().getProtocol(KnownProtocolKind::ObjectiveCBridgeable); M.getASTContext().getProtocol(KnownProtocolKind::ObjectiveCBridgeable);
auto Conf = *M.getSwiftModule()->lookupConformance(Target, BridgedProto); auto Conf = *M.getSwiftModule()->lookupConformance(Target, BridgedProto);
auto ParamTypes = BridgedFunc->getLoweredFunctionType()->getParameters(); auto ParamTypes = bridgingFunc->getLoweredFunctionType()->getParameters();
auto *FuncRef = Builder.createFunctionRef(Loc, BridgedFunc); auto *FuncRef = Builder.createFunctionRef(Loc, bridgingFunc);
auto MetaTy = MetatypeType::get(Target, MetatypeRepresentation::Thick); auto MetaTy = MetatypeType::get(Target, MetatypeRepresentation::Thick);
auto SILMetaTy = F->getTypeLowering(MetaTy).getLoweredType(); auto SILMetaTy = F->getTypeLowering(MetaTy).getLoweredType();