averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Also disable SwiftMergeFunctionsPass on top of LLVM MergeFunctions when VFE/WME is on (#40016)

Browse Source
This commit is contained in:
Kuba (Brecka) Mracek
2021-11-02 17:57:01 -07:00
committed by GitHub
parent ebe93b8145
commit afe116b1d4
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/IRGen/IRGen.cpp
View File

@@ -231,11 +231,15 @@ void swift::performLLVMOptimizations(const IRGenOptions &Opts,
llvm::createAlwaysInlinerLegacyPass(/*insertlifetime*/false);
}
// LLVM MergeFunctions doesn't understand the string in the metadata on calls
// in @llvm.type.checked.load intrinsics is important, and mis-compiles
// (mis-merge) unrelated functions.
if (Opts.VirtualFunctionElimination || Opts.WitnessMethodElimination)
bool RunSwiftMergeFunctions = true;
// LLVM MergeFunctions and SwiftMergeFunctions don't understand that the
// string in the metadata on calls in @llvm.type.checked.load intrinsics is
// semantically meaningful, and mis-compile (mis-merge) unrelated functions.
if (Opts.VirtualFunctionElimination || Opts.WitnessMethodElimination) {
PMBuilder.MergeFunctions = false;
RunSwiftMergeFunctions = false;
}
bool RunSwiftSpecificLLVMOptzns =
!Opts.DisableSwiftSpecificLLVMOptzns && !Opts.DisableLLVMOptzns;
@@ -274,7 +278,7 @@ void swift::performLLVMOptimizations(const IRGenOptions &Opts,
PMBuilder.addExtension(PassManagerBuilder::EP_EnabledOnOptLevel0,
addSanitizerCoveragePass);
}
if (RunSwiftSpecificLLVMOptzns) {
if (RunSwiftSpecificLLVMOptzns && RunSwiftMergeFunctions) {
PMBuilder.addExtension(PassManagerBuilder::EP_OptimizerLast,
[&](const PassManagerBuilder &Builder, PassManagerBase &PM) {
if (Builder.OptLevel > 0) {