averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue #72085 where BinaryExpr fix-it suggested missing operator.

Browse Source
This commit is contained in:
Crazy凡
2024-03-06 00:21:44 +08:00
committed by kongkaikai
parent 8854438d87
commit b2c054a59c
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Sema/CSDiagnostics.cpp
View File

@@ -5863,12 +5863,16 @@ bool OutOfOrderArgumentFailure::diagnoseAsError() {
// Move requires postfix comma only if argument is moved in-between
// other arguments.
bool requiresComma =
!isExpr<BinaryExpr>(anchor) && PrevArgIdx != args->size() - 1;
std::string argumentSeparator;
if (auto *BE = getAsExpr<BinaryExpr>(anchor)) {
auto operatorName = std::string(*getOperatorName(BE->getFn()));
argumentSeparator = " " + operatorName + " ";
} else if (PrevArgIdx != args->size() - 1) {
argumentSeparator = ", ";
}
diag.fixItRemove(removalRange);
diag.fixItInsert(secondRange.Start,
text.str() + (requiresComma ? ", " : ""));
diag.fixItInsert(secondRange.Start, text.str() + argumentSeparator);
};
// There are 4 diagnostic messages variations depending on