averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[FixCode] When picking-up fixits for migration ignore argument label fixits.

Browse Source 
These interact badly with the swift migrator, they are undoing migration of arguments to preserve the no-label for first argument.
This commit is contained in:
Argyrios Kyrtzidis
2016-05-24 16:30:10 -07:00
parent 54966d5700
commit b4a2b53739
3 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/FrontendTool/FrontendTool.cpp
View File

@@ -557,6 +557,11 @@ private:
// Do not add a semi as it is wrong in most cases during migration
if (Info.ID == diag::statement_same_line_without_semi.ID)
return false;
// The following interact badly with the swift migrator, they are undoing
// migration of arguments to preserve the no-label for first argument.
if (Info.ID == diag::witness_argument_name_mismatch.ID ||
Info.ID == diag::missing_argument_labels.ID)
return false;
if (Kind == DiagnosticKind::Error)
return true;