averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Frontend: Replace the abi magic value accepted by -target-min-inlining-version with a min magic value instead. The new value corresponds to the OS versions in which Swift was introduced. The introduction OS is a better floor for availability checking than the OS in which Swift became ABI stable because inlinable functions may reference clang declarations which have availability between Swift's introduction and ABI stability and framework developers ought to get diagnostics for unguarded use of those APIs in inlinable code.

Browse Source
This commit is contained in:
Allan Shortlidge
2022-03-14 11:23:26 -07:00
parent f807ef92e6
commit b563dc0736
4 changed files with 64 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Frontend/CompilerInvocation.cpp
View File

@@ -803,15 +803,12 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
// First, set up default minimum inlining target versions.
auto getDefaultMinimumInliningTargetVersion =
[&](const llvm::Triple &triple) -> llvm::VersionTuple {
#if SWIFT_DEFAULT_TARGET_MIN_INLINING_VERSION_TO_ABI
// In ABI-stable modules, default to the version where the target's ABI
// was first frozen; older versions will use that one's backwards
// compatibility libraries.
#if SWIFT_DEFAULT_TARGET_MIN_INLINING_VERSION_TO_MIN
// In ABI-stable modules, default to the version when Swift first became
// available.
if (FrontendOpts.EnableLibraryEvolution)
if (auto abiStability = minimumABIStableOSVersionForTriple(triple))
// FIXME: Should we raise it to the minimum supported OS version for
// architectures which were born ABI-stable?
return *abiStability;
if (auto minTriple = minimumAvailableOSVersionForTriple(triple))
return minTriple;
#endif
// In ABI-unstable modules, we will never have to interoperate with
@@ -834,10 +831,10 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
if (!A)
return None;
if (StringRef(A->getValue()) == "min")
return minimumAvailableOSVersionForTriple(Opts.Target);
if (StringRef(A->getValue()) == "target")
return Opts.getMinPlatformVersion();
if (StringRef(A->getValue()) == "abi")
return minimumABIStableOSVersionForTriple(Opts.Target);
if (auto vers = version::Version::parseVersionString(A->getValue(),
SourceLoc(), &Diags))