averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Sema] Add miscellaneous sema diagnostics to check that the new os log

Browse Source 
APIs and atomic operations are passed compile-time constants for
certain arguments.
This commit is contained in:
Ravi Kandhadai
2020-03-31 14:20:48 -07:00
parent fccfa29240
commit b57a1d7c0e
16 changed files with 872 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
test/SILOptimizer/OSLogCompilerDiagnosticsTest.swift
View File

@@ -3,62 +3,37 @@
// REQUIRES: OS=macosx || OS=ios || OS=tvos || OS=watchos
// Tests for the diagnostics produced by the OSLogOptimization pass that
// performs compile-time analysis and optimization of the new os log prototype
// APIs. The tests here check whether bad user inputs are diagnosed correctly.
// The tests here model the possible invalid inputs to the os log methods.
// TODO: diagnostics will be improved. globalStringTablePointer builtin error
// must be suppressed.
// performs compile-time analysis and optimization of the new os log APIs.
// Note that many usage errors are caught by the Sema check: ConstantnessSemaDiagnostics.
// The tests here check only those diagnostics that are enforced at the SIL level.
// TODO: diagnostics must be improved, and globalStringTablePointer builtin error must be
// suppressed.
import OSLogTestHelper
func testDynamicLogMessage(message: OSLogMessage) {
_osLogTestHelper(message)
// expected-error @-1 {{globalStringTablePointer builtin must used only on string literals}}
func testNonDecimalFormatOptionOnIntegers() {
_osLogTestHelper("Minimum integer value: \(Int.min, format: .hex)")
// expected-error @-1 {{evaluation of constant-evaluable function 'OSLogInterpolation.appendInterpolation(_:format:align:privacy:)' failed}}
// expected-note @-2 {{Fatal error: Signed integers must be formatted using .decimal}}
// expected-error @-3 {{globalStringTablePointer builtin must used only on string literals}}
}
func testNonconstantFormatOption(formatOpt: OSLogIntegerFormatting) {
_osLogTestHelper("Minimum integer value: \(Int.min, format: formatOpt)")
// expected-error @-1 {{interpolation arguments like format and privacy options must be constants}}
// expected-error @-2 {{globalStringTablePointer builtin must used only on string literals}}
// Extending OSLogInterpolation (without the constant_evaluable attribute) would be an
// error.
struct A {
var i: Int
}
func testNonconstantPrivacyOption( privacyOpt: OSLogPrivacy) {
_osLogTestHelper("Minimum integer value: \(Int.min, privacy: privacyOpt)")
// expected-error @-1 {{interpolation arguments like format and privacy options must be constants}}
// expected-error @-2 {{globalStringTablePointer builtin must used only on string literals}}
}
func testNoninlinedOSLogMessage() {
let logMessage: OSLogMessage = "Minimum integer value: \(Int.min)"
// expected-error @-1 {{OSLogMessage instance must not be explicitly created and must be deletable}}
_osLogTestHelper(logMessage)
}
func testNoninlinedOSLogMessageComplex(b: Bool) {
let logMessage: OSLogMessage = "Maximum integer value: \(Int.max)"
// expected-error @-1 {{OSLogMessage instance must not be explicitly created and must be deletable}}
if !b {
return
extension OSLogInterpolation {
mutating func appendInterpolation(a: A) {
self.appendInterpolation(a.i)
}
_osLogTestHelper(logMessage)
// expected-error @-1 {{globalStringTablePointer builtin must used only on string literals}}
}
func testNoninlinedFormatOptions() {
let formatOption: OSLogIntegerFormatting = .hex(includePrefix: true)
_osLogTestHelper("Minimum integer value: \(Int.min, format: formatOption)")
// expected-error @-1 {{interpolation arguments like format and privacy options must be constants}}
// expected-error @-2 {{globalStringTablePointer builtin must used only on string literals}}
}
func testNoninlinedFormatOptionsComplex(b: Bool) {
let formatOption: OSLogIntegerFormatting = .hex(includePrefix: true)
if !b {
return
}
_osLogTestHelper("Minimum integer value: \(Int.min, format: formatOption)")
// expected-error @-1 {{interpolation arguments like format and privacy options must be constants}}
// expected-error @-2 {{globalStringTablePointer builtin must used only on string literals}}
func testOSLogInterpolationExtension(a: A) {
_osLogTestHelper("Error at line: \(a: a)")
// expected-error @-1 {{evaluation of constant-evaluable function 'OSLogInterpolation.appendLiteral(_:)' failed}}
// expected-note @-2 {{value mutable by an unevaluated instruction is not a constant}}
// expected-error @-3 {{globalStringTablePointer builtin must used only on string literals}}
}
internal enum Color {