averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ParseDecl] Disallow init accessor decl outside of primary declaration

Browse Source
This commit is contained in:
li3zhen1
2024-05-02 20:48:29 -07:00
parent da5dd94bb7
commit b82fb851f9
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/swift/AST/DiagnosticsParse.def
View File

@@ -2156,6 +2156,10 @@ ERROR(init_accessor_is_not_on_property,none,
"init accessors could only be associated with properties",
())
ERROR(init_accessor_is_not_in_the_primary_declaration,none,
"init accessors could only be declared in the primary declaration",
())
ERROR(missing_storage_restrictions_attr_label,none,
"missing label in @storageRestrictions attribute", ())

6
lib/Parse/ParseDecl.cpp
View File

@@ -8432,7 +8432,11 @@ void Parser::ParsedAccessors::classify(Parser &P, AbstractStorageDecl *storage,
}
if (Init) {
if (!storage->getDeclContext()->getSelfNominalTypeDecl() ||
if (storage->getDeclContext()->getContextKind() ==
DeclContextKind::ExtensionDecl) {
P.diagnose(Init->getLoc(),
diag::init_accessor_is_not_in_the_primary_declaration);
} else if (!storage->getDeclContext()->getSelfNominalTypeDecl() ||
isa<SubscriptDecl>(storage)) {
P.diagnose(Init->getLoc(), diag::init_accessor_is_not_on_property);
}