averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] Tailored diagnostics for reference equality operator mismatches

Browse Source
This commit is contained in:
Pavel Yaskevich
2019-09-11 10:51:50 -07:00
parent 973d58d56f
commit b898eaf326
6 changed files with 118 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
lib/Sema/ConstraintSystem.cpp
View File

@@ -2960,37 +2960,48 @@ bool constraints::isKnownKeyPathDecl(ASTContext &ctx, ValueDecl *decl) {
decl == ctx.getPartialKeyPathDecl() || decl == ctx.getAnyKeyPathDecl();
}
bool constraints::isPatternMatchingOperator(Expr *expr) {
static bool isOperator(Expr *expr, StringRef expectedName) {
auto name = getOperatorName(expr);
return name ? name->is(expectedName) : false;
}
Optional<Identifier> constraints::getOperatorName(Expr *expr) {
ValueDecl *choice = nullptr;
if (auto *ODRE = dyn_cast_or_null<OverloadedDeclRefExpr>(expr)) {
choice = ODRE->getDecls().front();
} else if (auto *DRE = dyn_cast_or_null<DeclRefExpr>(expr)) {
choice = DRE->getDecl();
} else {
return false;
return None;
}
if (auto *FD = dyn_cast_or_null<AbstractFunctionDecl>(choice)) {
auto name = FD->getBaseName().userFacingName();
return name == "~=";
}
if (auto *FD = dyn_cast_or_null<AbstractFunctionDecl>(choice))
return FD->getBaseName().getIdentifier();
return false;
return None;
}
bool constraints::isPatternMatchingOperator(Expr *expr) {
return isOperator(expr, "~=");
}
bool constraints::isArgumentOfPatternMatchingOperator(
ConstraintLocator *locator) {
Expr *anchor = nullptr;
if (locator->findLast<LocatorPathElt::ApplyArgToParam>()) {
anchor = locator->getAnchor();
} else {
return false;
}
auto *binaryOp = dyn_cast_or_null<BinaryExpr>(anchor);
auto *binaryOp = dyn_cast_or_null<BinaryExpr>(locator->getAnchor());
if (!(binaryOp && binaryOp->isImplicit()))
return false;
auto *fnExpr = binaryOp->getFn()->getSemanticsProvidingExpr();
return isPatternMatchingOperator(fnExpr);
return isPatternMatchingOperator(binaryOp->getFn());
}
bool constraints::isArgumentOfReferenceEqualityOperator(
ConstraintLocator *locator) {
if (!locator->findLast<LocatorPathElt::ApplyArgToParam>())
return false;
if (auto *binaryOp = dyn_cast_or_null<BinaryExpr>(locator->getAnchor())) {
auto *fnExpr = binaryOp->getFn();
return isOperator(fnExpr, "===") || isOperator(fnExpr, "!==");
}
return false;
}