averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Always put SILFunctions into a zombie list, when they are erased.

Browse Source 
This removes the function body, but preserves the SILFunction object, which may be still referenced by different kinds of meta-information e.g. debug info for inlined functions, generic specializations information, etc.

Doing this unconditionally simplifies the code and makes it less error-prone to reference SILFunctions from any kind of meta-information. It just works. No need to set any special flags, etc.
This commit is contained in:
Roman Levenstein
2017-08-11 11:14:19 -07:00
parent ca6f9f6d55
commit bae290cdab
3 changed files with 18 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
include/swift/SIL/SILFunction.h
View File

@@ -200,12 +200,6 @@ private:
/// after the pass runs, we only see a semantic-arc world.
bool HasQualifiedOwnership = true;
/// True if this function is referenced by any kind of meta-information. This
/// is the case e.g. when a function is referenced by the specialization
/// information. Setting this flag ensures that the functions becomes a zombie
/// function later.
bool ReferencedByMetainformation = false;
SILFunction(SILModule &module, SILLinkage linkage, StringRef mangledName,
CanSILFunctionType loweredType, GenericEnvironment *genericEnv,
Optional<SILLocation> loc, IsBare_t isBareSILFunction,
@@ -297,26 +291,13 @@ public:
/// Mark this function as removed from the module's function list, but kept
/// as "zombie" for debug info or vtable stub generation.
void setZombie() {
assert((isInlined() || isExternallyUsedSymbol() ||
isReferencedByMetainformation()) &&
"Function should be deleted instead of getting a zombie");
assert(!isZombie() && "Function is a zombie function already");
Zombie = true;
}
/// Returns true if this function is dead, but kept in the module's zombie list.
bool isZombie() const { return Zombie; }
/// Mark this function as referenced by meta-information.
void setReferencedByMetainformation() {
ReferencedByMetainformation = true;
}
/// Returns true if this function is referenced by any kind of
/// meta-information.
bool isReferencedByMetainformation() const {
return ReferencedByMetainformation;
}
/// Returns true if this function has qualified ownership instructions in it.
bool hasQualifiedOwnership() const { return HasQualifiedOwnership; }