averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

SIL Optimizer: Update outdated comment concerning transparent functions

Browse Source
This commit is contained in:
Slava Pestov
2018-04-16 16:29:48 -07:00
parent a2df485bf3
commit bb244b2812
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/SILOptimizer/Transforms/Devirtualizer.cpp
View File

@@ -93,11 +93,9 @@ bool Devirtualizer::devirtualizeAppliesInFunction(SILFunction &F,
assert(CalleeFn && "Expected devirtualized callee!");
// We need to ensure that we link after devirtualizing in order to pull in
// everything we reference from another module. This is especially important
// for transparent functions, because if transparent functions are not
// inlined for some reason, we need to generate code for them.
// Note that functions, which are only referenced from witness/vtables, are
// not linked upfront by the SILLinker.
// everything we reference from another module, which may expose optimization
// opportunities and is also needed for correctness if we reference functions
// with non-public linkage. See lib/SIL/Linker.cpp for details.
if (!CalleeFn->isDefinition())
F.getModule().linkFunction(CalleeFn, SILModule::LinkingMode::LinkAll);