averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: Rename GenericContext::isGeneric to hasGenericParamList

Browse Source 
`isGeneric` is a misleading name because this method checks for the
existence of a `GenericParamList`, which is not implied by genericity.
This commit is contained in:
Anthony Latsis
2025-11-11 14:23:35 +00:00
parent 75506a17ce
commit bda6edb85c
45 changed files with 106 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp
View File

@@ -273,8 +273,8 @@ static void initDocGenericParams(const Decl *D, DocEntityInfo &Info,
return;
// The declaration may not be generic itself, but instead carry additional
// generic requirements in a contextual where clause, so checking !isGeneric()
// is insufficient.
// generic requirements in a contextual where clause, so checking
// !hasGenericParamList() is insufficient.
const auto ParentSig = GC->getParent()->getGenericSignatureOfContext();
if (ParentSig && ParentSig->isEqual(GenericSig))
return;
@@ -316,7 +316,7 @@ static void initDocGenericParams(const Decl *D, DocEntityInfo &Info,
};
// FIXME: Not right for extensions of nested generic types
if (GC->isGeneric()) {
if (GC->hasGenericParamList()) {
for (auto *GP : GenericSig.getInnermostGenericParams()) {
if (GP->getDecl()->isImplicit())
continue;