averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove default value for the keepUnique argument of Builder.createEndCOWMutation

Browse Source 
This avoids bugs because the default value false is sometimes not the right choice.
NFC
This commit is contained in:
Erik Eckstein
2023-12-06 15:39:59 +01:00
parent d4b1172537
commit bfeb2128cb
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
SwiftCompilerSources/Sources/SIL/Builder.swift
View File

@@ -346,7 +346,7 @@ public struct Builder {
return notifyNew(metatype.getAs(MetatypeInst.self)) return notifyNew(metatype.getAs(MetatypeInst.self))
} }
public func createEndCOWMutation(instance: Value, keepUnique: Bool = false) -> EndCOWMutationInst { public func createEndCOWMutation(instance: Value, keepUnique: Bool) -> EndCOWMutationInst {
let endMutation = bridged.createEndCOWMutation(instance.bridged, keepUnique) let endMutation = bridged.createEndCOWMutation(instance.bridged, keepUnique)
return notifyNew(endMutation.getAs(EndCOWMutationInst.self)) return notifyNew(endMutation.getAs(EndCOWMutationInst.self))
} }

2
include/swift/SIL/SILBuilder.h
View File

@@ -2287,7 +2287,7 @@ public:
Int1Ty, getFunction(), isNative)); Int1Ty, getFunction(), isNative));
} }
EndCOWMutationInst *createEndCOWMutation(SILLocation Loc, SILValue operand, EndCOWMutationInst *createEndCOWMutation(SILLocation Loc, SILValue operand,
bool keepUnique = false) { bool keepUnique) {
return insert(new (getModule()) EndCOWMutationInst(getSILDebugLocation(Loc), return insert(new (getModule()) EndCOWMutationInst(getSILDebugLocation(Loc),
operand, keepUnique)); operand, keepUnique));
} }

2
lib/SILGen/SILGenBuiltin.cpp
View File

@@ -1019,7 +1019,7 @@ emitBuiltinEndCOWMutation(SILGenFunction &SGF,
SILValue refAddr = args[0].getValue(); SILValue refAddr = args[0].getValue();
auto ref = SGF.B.createLoad(loc, refAddr, LoadOwnershipQualifier::Take); auto ref = SGF.B.createLoad(loc, refAddr, LoadOwnershipQualifier::Take);
auto endRef = SGF.B.createEndCOWMutation(loc, ref); auto endRef = SGF.B.createEndCOWMutation(loc, ref, /*keepUnique=*/ false);
SGF.B.createStore(loc, endRef, refAddr, StoreOwnershipQualifier::Init); SGF.B.createStore(loc, endRef, refAddr, StoreOwnershipQualifier::Init);
return ManagedValue::forObjectRValueWithoutOwnership(SGF.emitEmptyTuple(loc)); return ManagedValue::forObjectRValueWithoutOwnership(SGF.emitEmptyTuple(loc));
} }