averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

SIL: simplify deleting instruction while iterating over instructions.

Browse Source 
Add `deletableInstructions()` and `reverseDeletableInstructions()` in SILBasicBlock.
It allows deleting instructions while iterating over all instructions of the block.
This is a replacement for `InstructionDeleter::updatingRange()`.
It's a simpler implementation than the existing `UpdatingListIterator` and `UpdatingInstructionIteratorRegistry`, because it just needs to keep the prev/next pointers for "deleted" instructions instead of the iterator-registration machinery.
It's also safer, because it doesn't require to delete instructions via a specific instance of an InstructionDeleter (which can be missed easily).
This commit is contained in:
Erik Eckstein
2022-12-02 15:21:23 +01:00
parent 05a63c70c5
commit c180d1363e
12 changed files with 143 additions and 339 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/SILOptimizer/Transforms/GenericSpecializer.cpp
View File

@@ -291,8 +291,8 @@ bool MandatoryGenericSpecializer::optimize(SILFunction *func,
if (!rrBlocks.reachesReturn(&block) || !neBlocks.isNonErrorHandling(&block))
continue;
for (SILInstruction *inst : deleter.updatingReverseRange(&block)) {
changed |= optimizeInst(inst, funcBuilder, deleter, cha, invalidatedStackNesting);
for (SILInstruction &inst : block.reverseDeletableInstructions()) {
changed |= optimizeInst(&inst, funcBuilder, deleter, cha, invalidatedStackNesting);
}
}
deleter.cleanupDeadInstructions();