averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[gardening] Avoid fallthrough where appropriate (for readability/understandability)

Browse Source
This commit is contained in:
Sho Ikeda
2019-05-26 09:49:44 +09:00
parent b088acb66e
commit c1bb945124
2 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
stdlib/public/Darwin/Foundation/IndexPath.swift
View File

@@ -218,8 +218,8 @@ public struct IndexPath : ReferenceConvertible, Equatable, Hashable, MutableColl
}
case .single(let index):
switch (range.lowerBound, range.upperBound) {
case (0, 0): fallthrough
case (1, 1):
case (0, 0),
(1, 1):
return .empty
case (0, 1):
return .single(index)
@@ -228,11 +228,9 @@ public struct IndexPath : ReferenceConvertible, Equatable, Hashable, MutableColl
}
case .pair(let first, let second):
switch (range.lowerBound, range.upperBound) {
case (0, 0):
fallthrough
case (1, 1):
fallthrough
case (2, 2):
case (0, 0),
(1, 1),
(2, 2):
return .empty
case (0, 1):
return .single(first)
@@ -264,9 +262,8 @@ public struct IndexPath : ReferenceConvertible, Equatable, Hashable, MutableColl
self = newValue
case .single(let index):
switch (range.lowerBound, range.upperBound, newValue) {
case (0, 0, .empty):
fallthrough
case (1, 1, .empty):
case (0, 0, .empty),
(1, 1, .empty):
break
case (0, 0, .single(let other)):
self = .pair(other, index)
@@ -274,13 +271,10 @@ public struct IndexPath : ReferenceConvertible, Equatable, Hashable, MutableColl
self = .array([first, second, index])
case (0, 0, .array(let other)):
self = .array(other + [index])
case (0, 1, .empty):
fallthrough
case (0, 1, .single):
fallthrough
case (0, 1, .pair):
fallthrough
case (0, 1, .array):
case (0, 1, .empty),
(0, 1, .single),
(0, 1, .pair),
(0, 1, .array):
self = newValue
case (1, 1, .single(let other)):
self = .pair(index, other)