averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix ASAN stack-use-after-scope errors Basic/TaskQueueTest.cpp

Browse Source 
The issue was that in three tests, the `Args` arrays were being declared inside
for loops.

When `TQ.addTask()` was called, it stored a pointer to the `Args` array. As the
`Args` array was declared in the loop, it would go out of scope at the end of
each iteration whilst `TaskQueue` held a pointer to it.
This commit is contained in:
Kushal Pisavadia
2025-10-23 11:00:27 +01:00
parent 0e4dc2fe2e
commit c2a1a20cac
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
unittests/Basic/TaskQueueTest.cpp
View File

@@ -149,8 +149,8 @@ TEST(TaskQueueTest, HighConcurrency) {
return TaskFinishedResponse::ContinueExecution;
};
const char *Args[] = {"test", nullptr};
for (int i = 0; i < 50; i++) {
const char *Args[] = {"test", nullptr};
TQ.addTask("/bin/echo", Args, llvm::ArrayRef<const char *>(), nullptr, false);
}
@@ -182,8 +182,8 @@ TEST(TaskQueueTest, TaskBeganCallback) {
return TaskFinishedResponse::ContinueExecution;
};
const char *Args[] = {"echo", "test", nullptr};
for (int i = 0; i < 3; i++) {
const char *Args[] = {"echo", "test", nullptr};
TQ.addTask("/bin/echo", Args, llvm::ArrayRef<const char *>(), nullptr, false);
}
@@ -219,8 +219,8 @@ TEST(TaskQueueTest, StopExecutionOnFailure) {
return TaskFinishedResponse::ContinueExecution;
};
const char *Args[] = {"test", nullptr};
for (int i = 0; i < 10; i++) {
const char *Args[] = {"test", nullptr};
TQ.addTask("/bin/echo", Args, llvm::ArrayRef<const char *>(), nullptr, false);
}