averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix _StringObject.init(object:...)

Browse Source 
Add a missing fix_lifetime. This miscompiles with OSSA because
`object` is destroyed before `bridgeObject` is retained.

Reinterpreting a reference to a trivial type always requires a
fix_lifetime.
This commit is contained in:
Andrew Trick
2020-12-30 00:27:10 -08:00
parent 949b0c0cc3
commit c4661b9b47
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
stdlib/public/core/StringObject.swift
View File

@@ -207,6 +207,7 @@ extension _StringObject {
internal init( internal init(
object: AnyObject, discriminator: UInt64, countAndFlags: CountAndFlags object: AnyObject, discriminator: UInt64, countAndFlags: CountAndFlags
) { ) {
defer { _fixLifetime(object) }
let builtinRawObject: Builtin.Int64 = Builtin.reinterpretCast(object) let builtinRawObject: Builtin.Int64 = Builtin.reinterpretCast(object)
let builtinDiscrim: Builtin.Int64 = discriminator._value let builtinDiscrim: Builtin.Int64 = discriminator._value
self.init( self.init(