averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #26816 from jrose-apple/cant-stand-the-rain

Browse Source 
Fix a pair of leaks related to FileUnit destructors not being run
This commit is contained in:
Jordan Rose
2019-08-26 11:06:54 -07:00
committed by GitHub
parent aed25d1c14 5c785d42b3
commit c50113185f
12 changed files with 46 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/AST/Module.cpp
View File

@@ -55,6 +55,11 @@
using namespace swift;
static_assert(IsTriviallyDestructible<FileUnit>::value,
"FileUnits are BumpPtrAllocated; the d'tor may not be called");
static_assert(IsTriviallyDestructible<LoadedFile>::value,
"LoadedFiles are BumpPtrAllocated; the d'tor may not be called");
//===----------------------------------------------------------------------===//
// Builtin Module Name lookup
//===----------------------------------------------------------------------===//
@@ -1249,10 +1254,6 @@ StringRef ModuleDecl::getModuleFilename() const {
// per-file names. Modules can consist of more than one file.
StringRef Result;
for (auto F : getFiles()) {
Result = F->getParseableInterface();
if (!Result.empty())
return Result;
if (auto SF = dyn_cast<SourceFile>(F)) {
if (!Result.empty())
return StringRef();