averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-module-digester: diagnose optional protocol requirement changes.

Browse Source
This commit is contained in:
Xi Ge
2018-09-27 13:45:20 -07:00
parent 3dfe615d27
commit c5444a8e99
8 changed files with 35 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -775,7 +775,17 @@ static void detectDeclChange(NodePtr L, NodePtr R, SDKContext &Ctx) {
Diags.diagnose(SourceLoc(), diag::generic_sig_change, LD->getScreenInfo(),
LD->getGenericSignature(), RD->getGenericSignature());
}
if (LD->isOptional() != RD->isOptional()) {
if (Ctx.checkingABI()) {
// Both adding/removing optional is ABI-breaking.
Diags.diagnose(SourceLoc(), diag::optional_req_changed,
LD->getScreenInfo(), LD->isOptional());
} else if (LD->isOptional()) {
// Removing optional is source-breaking.
Diags.diagnose(SourceLoc(), diag::optional_req_changed,
LD->getScreenInfo(), LD->isOptional());
}
}
if (auto *LDT = dyn_cast<SDKNodeDeclType>(L)) {
if (auto *RDT = dyn_cast<SDKNodeDeclType>(R)) {
diagnoseNominalTypeDeclChange(LDT, RDT);