averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Distributed] Handle mangling thunks in extensions with generic AS and $Stubs (#71914)

Browse Source
This commit is contained in:
Konrad `ktoso` Malawski
2024-02-29 21:22:00 +09:00
committed by GitHub
parent 92f3b0f2c4
commit c56a1e8be7
29 changed files with 565 additions and 296 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
lib/Sema/CodeSynthesisDistributedActor.cpp
View File

@@ -195,6 +195,7 @@ static void forwardParameters(AbstractFunctionDecl *afd,
}
}
/// Mangle the target thunk in a way that we can look up the appropriate record.
static llvm::StringRef
mangleDistributedThunkForAccessorRecordName(
ASTContext &C, AbstractFunctionDecl *thunk) {
@@ -202,7 +203,7 @@ mangleDistributedThunkForAccessorRecordName(
// default mangling
auto mangled =
C.AllocateCopy(mangler.mangleDistributedThunk(cast<FuncDecl>(thunk)));
C.AllocateCopy(mangler.mangleDistributedThunkRef(cast<FuncDecl>(thunk)));
return mangled;
}
@@ -217,8 +218,8 @@ deriveBodyDistributed_thunk(AbstractFunctionDecl *thunk, void *context) {
auto func = static_cast<FuncDecl *>(context);
auto funcDC = func->getDeclContext();
NominalTypeDecl *nominal = funcDC->getSelfNominalTypeDecl();
assert(nominal && nominal->isDistributedActor() &&
assert(funcDC->getSelfNominalTypeDecl() &&
funcDC->getSelfNominalTypeDecl()->isDistributedActor() &&
"Distributed function must be part of distributed actor");
auto selfDecl = thunk->getImplicitSelfDecl();
@@ -730,9 +731,6 @@ static FuncDecl *createDistributedThunkFunction(FuncDecl *func) {
return nullptr;
}
assert(getConcreteReplacementForProtocolActorSystemType(func) &&
"Thunk synthesis must have concrete actor system type available");
DeclName thunkName;
// Since accessors don't have names, let's generate one based on
@@ -875,6 +873,23 @@ void swift::assertRequiredSynthesizedPropertyOrder(ASTContext &Context,
#endif
}
static bool canSynthesizeDistributedThunk(AbstractFunctionDecl *distributedTarget) {
if (getConcreteReplacementForProtocolActorSystemType(distributedTarget)) {
return true;
}
auto &C = distributedTarget->getASTContext();
ProtocolDecl *DistributedActor = C.getDistributedActorDecl();
SmallPtrSet<ProtocolDecl *, 2> requirementProtos;
if (getSerializationRequirementTypesForMember(distributedTarget,
requirementProtos)) {
return true;
}
return false;
}
/******************************************************************************/
/*********************** SYNTHESIS ENTRY POINTS *******************************/
/******************************************************************************/
@@ -910,10 +925,7 @@ FuncDecl *GetDistributedThunkRequest::evaluate(Evaluator &evaluator,
auto &C = distributedTarget->getASTContext();
if (!getConcreteReplacementForProtocolActorSystemType(distributedTarget)) {
// Don't synthesize thunks, unless there is a *concrete* ActorSystem.
// TODO(distributed): we should be able to lift this eventually,
// and allow resolving distributed actor protocols.
if (!canSynthesizeDistributedThunk(distributedTarget)) {
return nullptr;
}