averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ModuleInterface] Address review comments.

Browse Source
This commit is contained in:
Graydon Hoare
2018-11-08 20:51:07 -08:00
parent 9d7d66806f
commit c6ac3867cd
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Frontend/ParseableInterfaceSupport.cpp
View File

@@ -228,9 +228,9 @@ collectDepsForSerialization(clang::vfs::FileSystem &FS,
InitialDepNames.push_back(InPath);
llvm::StringSet<> AllDepNames;
for (auto const &DepName : InitialDepNames) {
AllDepNames.insert(DepName);
if (OuterTracker)
OuterTracker->addDependency(DepName, /*IsSystem=*/false);
if (AllDepNames.insert(DepName).second && OuterTracker) {
OuterTracker->addDependency(DepName, /*IsSystem=*/false);
}
auto DepBuf = getBufferOfDependency(FS, InPath, DepName, Diags);
if (!DepBuf) {
return true;
@@ -258,8 +258,7 @@ collectDepsForSerialization(clang::vfs::FileSystem &FS,
return true;
}
for (auto const &SubDep : SubDeps) {
if (AllDepNames.count(SubDep.Path) == 0) {
AllDepNames.insert(SubDep.Path);
if (AllDepNames.insert(SubDep.Path).second) {
Deps.push_back(SubDep);
if (OuterTracker)
OuterTracker->addDependency(SubDep.Path, /*IsSystem=*/false);