averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] Try to find overlap between src/dst protocols in assignment mismatch

Browse Source
This commit is contained in:
Pavel Yaskevich
2019-10-29 16:50:47 -07:00
parent 6670d628ca
commit c800bde8e1
3 changed files with 65 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lib/Sema/CSSimplify.cpp
View File

@@ -4610,13 +4610,21 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyConformsToConstraint(
// protocol compositions.
if (anchor && isa<AssignExpr>(anchor)) {
auto *assignment = cast<AssignExpr>(anchor);
auto srcType = getType(assignment->getSrc())->getWithoutSpecifierType();
// If the source type is something that can't possibly conform
// to a protocol e.g. a function type, let's record this is a
// type mismatch, otherwise this is a specific missing conformance.
auto dstType = srcType->is<FunctionType>()
? getType(assignment->getDest())
: protocolTy;
// If the locator's last element points to the function result,
// let's check whether there is a problem with function argument
// as well, and if so, avoid producing a fix here, because
// contextual mismatch mentions the source/destination
// types of the assignment.
if (auto last = locator.last()) {
if (last->is<LocatorPathElt::FunctionResult>() &&
hasFixFor(getConstraintLocator(anchor,
LocatorPathElt::FunctionArgument())))
return SolutionKind::Solved;
}
auto srcType = getType(assignment->getSrc());
auto dstType = getType(assignment->getDest());
auto *fix = IgnoreAssignmentDestinationType::create(
*this, srcType, dstType, getConstraintLocator(locator));