averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Reflection] Cache the various DataQuery values.

Browse Source 
We can end up querying the pointer size and similar things very frequently, which can be slow. These values don't change for any given reader, so call them once and cache the values locally instead.

rdar://150221008
This commit is contained in:
Mike Ash
2025-06-30 17:00:08 -04:00
parent d203591201
commit ca06ced1d2
4 changed files with 101 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
include/swift/Remote/CMemoryReader.h
View File

@@ -42,38 +42,16 @@ namespace remote {
class CMemoryReader final : public MemoryReader {
MemoryReaderImpl Impl;
uint64_t ptrauthMask;
uint64_t getPtrauthMask() {
if (ptrauthMask == 0) {
int success;
if (Impl.PointerSize == 4) {
uint32_t ptrauthMask32 = 0;
success = queryDataLayout(DataLayoutQueryType::DLQ_GetPtrAuthMask,
nullptr, &ptrauthMask32);
ptrauthMask = ptrauthMask32;
} else if (Impl.PointerSize == 8) {
success = queryDataLayout(DataLayoutQueryType::DLQ_GetPtrAuthMask,
nullptr, &ptrauthMask);
} else {
success = 0;
}
if (!success)
ptrauthMask = ~0ull;
}
return ptrauthMask;
}
// Check to see if an address has bits outside the ptrauth mask. This suggests
// that we're likely failing to strip a signed pointer when reading from it.
bool hasSignatureBits(RemoteAddress address) {
uint64_t addressData = address.getAddressData();
return addressData != (addressData & getPtrauthMask());
uint64_t mask = getPtrAuthMask().value_or(~uint64_t(0));
return addressData != (addressData & mask);
}
public:
CMemoryReader(MemoryReaderImpl Impl) : Impl(Impl), ptrauthMask(0) {
CMemoryReader(MemoryReaderImpl Impl) : Impl(Impl) {
assert(this->Impl.queryDataLayout && "No queryDataLayout implementation");
assert(this->Impl.getStringLength && "No stringLength implementation");
assert(this->Impl.readBytes && "No readBytes implementation");