factoring and commenting

This commit is contained in:
David Ungar
2018-08-03 09:10:43 -07:00
parent b4b3b0fcec
commit cb3af7c0d4
3 changed files with 93 additions and 43 deletions

View File

@@ -1618,12 +1618,8 @@ createDispatchingDiagnosticConsumerIfNeeded(
return false;
});
}
if (subconsumers.empty())
return nullptr;
if (subconsumers.size() == 1)
return std::move(subconsumers.front()).consumer;
return llvm::make_unique<FileSpecificDiagnosticConsumer>(subconsumers);
return FileSpecificDiagnosticConsumer::consolidateSubconsumers(subconsumers);
}
/// Creates a diagnostic consumer that handles serializing diagnostics, based on