averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62480 from eeckstein/instruction-iteration

Browse Source 
SIL: simplify deleting instructions while iterating over instructions.
This commit is contained in:
eeckstein
2022-12-13 10:45:06 +01:00
committed by GitHub
parent 4ca5d1e7ee d4d1620f28
commit cb6737269d
34 changed files with 642 additions and 476 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/SILOptimizer/Mandatory/AddressLowering.cpp
View File

@@ -3895,9 +3895,9 @@ static void deleteRewrittenInstructions(AddressLoweringState &pass) {
continue;
}
// willDeleteInstruction was already called for open_existential_value to
// update the registered type. Carry out the remaining deletion steps.
deadInst->getParent()->remove(deadInst);
pass.getModule()->scheduleForDeletion(deadInst);
// update the registered type. Now fully erase the instruction, which will
// harmlessly call willDeleteInstruction again.
deadInst->getParent()->erase(deadInst);
}
pass.valueStorageMap.clear();