averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ConstraintSystem] NFC: Leave notes on the algorithm used by diagnoseAmbiguityWithFixes

Browse Source
This commit is contained in:
Pavel Yaskevich
2020-05-11 13:53:12 -07:00
parent 7d3f5e3775
commit cf3f52c94d
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Sema/ConstraintSystem.cpp
View File

@@ -3197,6 +3197,16 @@ bool ConstraintSystem::diagnoseAmbiguityWithFixes(
if (diagnoseAmbiguityWithEphemeralPointers(*this, solutions))
return true;
// Algorithm is as follows:
//
// a. Aggregate all of the available fixes based on callee locator;
// b. For each ambiguous overload match aggregated fixes and diagnose;
// c. Discard all of the fixes which have been already considered
// as part of overload diagnostics;
// d. Diagnose remaining (uniqued based on kind + locator) fixes
// iff they appear in all of the solutions.
using Fix = std::pair<const Solution *, const ConstraintFix *>;
llvm::SmallSetVector<Fix, 4> fixes;