averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSSimplify] Increase contextual element mismatch impact when related to Any{Hashable}

Browse Source 
Impact is higher in this case because it means that other collection
or a pattern (in case of for-in loop) is structurally incompatible with
collection's element type.
This commit is contained in:
Pavel Yaskevich
2022-11-01 17:09:43 -07:00
parent 3c0401c7cb
commit cf5d41c6dd
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/CSSimplify.cpp
View File

@@ -13850,6 +13850,14 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyFixConstraint(
impact = 10;
}
// Increase impact of invalid conversions to `Any` and `AnyHashable`
// associated with collection elements (i.e. for-in sequence element)
// because it means that other side is structurally incompatible.
if (fix->getKind() == FixKind::IgnoreCollectionElementContextualMismatch) {
if (type2->isAny() || type2->isAnyHashable())
++impact;
}
if (recordFix(fix, impact))
return SolutionKind::Error;