averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Accessibility] When a private type is used in a public way, show its decl.

Browse Source 
At the very least, this makes it easier to mark the private type as public
if that's the correct answer.

Swift SVN r19436
This commit is contained in:
Jordan Rose
2014-07-01 23:42:01 +00:00
parent 287059b360
commit cfd7851a67
5 changed files with 69 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/swift/AST/DiagnosticEngine.h
View File

@@ -392,7 +392,7 @@ namespace swift {
/// \brief The declaration of the currently active diagnostic, if there is
/// one.
Decl *ActiveDiagnosticDecl = nullptr;
const Decl *ActiveDiagnosticDecl = nullptr;
/// \brief The source location of the currently active diagnostic, if there
/// is one.
@@ -515,7 +515,7 @@ namespace swift {
///
/// \returns An in-flight diagnostic, to which additional information can
/// be attached.
InFlightDiagnostic diagnose(Decl *decl, DiagID id,
InFlightDiagnostic diagnose(const Decl *decl, DiagID id,
ArrayRef<DiagnosticArgument> args) {
assert(!ActiveDiagnostic && "Already have an active diagnostic");
ActiveDiagnosticLoc = SourceLoc();
@@ -534,7 +534,7 @@ namespace swift {
///
/// \returns An in-flight diagnostic, to which additional information can
/// be attached.
InFlightDiagnostic diagnose(Decl *decl, const Diagnostic &diag) {
InFlightDiagnostic diagnose(const Decl *decl, const Diagnostic &diag) {
assert(!ActiveDiagnostic && "Already have an active diagnostic");
ActiveDiagnosticLoc = SourceLoc();
ActiveDiagnosticDecl = decl;
@@ -553,7 +553,7 @@ namespace swift {
/// the types expected by the diagnostic \p ID.
template<typename ...ArgTypes>
InFlightDiagnostic
diagnose(Decl *decl, Diag<ArgTypes...> id,
diagnose(const Decl *decl, Diag<ArgTypes...> id,
typename detail::PassArgument<ArgTypes>::type... args) {
ActiveDiagnosticLoc = SourceLoc();
ActiveDiagnosticDecl = decl;