averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make internal stdlib functions public, which are called from the stdlib tests.

Browse Source 
And make sure that all those public identifiers are preceeded with underscores.

I marked these public-modifiers with "// @testable" to document why they are public.
If some day we have a @testable attribute it should be used instead of those public-modifiers.

Again, this is needed for enabling dead internal function elimination in the stdlib.



Swift SVN r22657
This commit is contained in:
Erik Eckstein
2014-10-10 09:45:10 +00:00
parent 3d8008117f
commit d0697f2ac1
19 changed files with 88 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
stdlib/core/Unicode.swift
View File

@@ -814,16 +814,19 @@ internal func _transcodeSomeUTF16AsUTF8<
/// Instances of conforming types are used in internal `String`
/// representation.
internal protocol _StringElementType {
public // @testable
protocol _StringElementType {
class func _toUTF16CodeUnit(_: Self) -> UTF16.CodeUnit
class func _fromUTF16CodeUnit(utf16: UTF16.CodeUnit) -> Self
}
extension UTF16.CodeUnit : _StringElementType {
internal static func _toUTF16CodeUnit(x: UTF16.CodeUnit) -> UTF16.CodeUnit {
public // @testable
static func _toUTF16CodeUnit(x: UTF16.CodeUnit) -> UTF16.CodeUnit {
return x
}
internal static func _fromUTF16CodeUnit(
public // @testable
static func _fromUTF16CodeUnit(
utf16: UTF16.CodeUnit
) -> UTF16.CodeUnit {
return utf16
@@ -831,11 +834,13 @@ extension UTF16.CodeUnit : _StringElementType {
}
extension UTF8.CodeUnit : _StringElementType {
internal static func _toUTF16CodeUnit(x: UTF8.CodeUnit) -> UTF16.CodeUnit {
public // @testable
static func _toUTF16CodeUnit(x: UTF8.CodeUnit) -> UTF16.CodeUnit {
_sanityCheck(x <= 0x7f, "should only be doing this with ASCII")
return UTF16.CodeUnit(x)
}
internal static func _fromUTF16CodeUnit(
public // @testable
static func _fromUTF16CodeUnit(
utf16: UTF16.CodeUnit
) -> UTF8.CodeUnit {
_sanityCheck(utf16 <= 0x7f, "should only be doing this with ASCII")
@@ -872,7 +877,8 @@ extension UTF16 {
) + 0xDC00
}
internal static func copy<T : _StringElementType, U : _StringElementType>(
public // @testable
static func _copy<T : _StringElementType, U : _StringElementType>(
source: UnsafeMutablePointer<T>,
destination: UnsafeMutablePointer<U>, count: Int
) {