averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[region-isolation] Add support for ref_to_raw_pointer, raw_pointer_to_ref, index_raw_pointer.

Browse Source
This commit is contained in:
Michael Gottesman
2023-12-19 14:36:33 -08:00
parent c90097f1f0
commit d08359eb20
2 changed files with 176 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
lib/SILOptimizer/Mandatory/TransferNonSendable.cpp
View File

@@ -194,6 +194,7 @@ struct UseDefChainVisitor
} // namespace
static SILValue getUnderlyingTrackedObjectValue(SILValue value) {
auto *fn = value->getFunction();
SILValue result = value;
while (true) {
SILValue temp = result;
@@ -208,6 +209,21 @@ static SILValue getUnderlyingTrackedObjectValue(SILValue value) {
}
}
if (auto *r = dyn_cast<RefToRawPointerInst>(temp)) {
// If our operand is a non-Sendable type, look through this instruction.
if (isNonSendableType(r->getOperand()->getType(), fn)) {
temp = r->getOperand();
}
}
if (auto *r = dyn_cast<RawPointerToRefInst>(temp)) {
// If our result is a non-Sendable type, look through this
// instruction. Builtin.RawPointer is always non-Sendable.
if (isNonSendableType(r->getType(), fn)) {
temp = r->getOperand();
}
}
if (auto *dsi = dyn_cast_or_null<DestructureStructInst>(
temp->getDefiningInstruction())) {
temp = dsi->getOperand();
@@ -2321,6 +2337,7 @@ CONSTANT_TRANSLATION(UncheckedAddrCastInst, Assign)
CONSTANT_TRANSLATION(UncheckedEnumDataInst, Assign)
CONSTANT_TRANSLATION(UncheckedOwnershipConversionInst, Assign)
CONSTANT_TRANSLATION(UnmanagedToRefInst, Assign)
CONSTANT_TRANSLATION(IndexRawPointerInst, Assign)
// These are used by SIL to aggregate values together in a gep like way. We
// want to look at uses of structs, not the struct uses itself. So just
@@ -2450,12 +2467,9 @@ CONSTANT_TRANSLATION(DeallocExistentialBoxInst, Ignored)
// Unhandled Instructions
//
CONSTANT_TRANSLATION(IndexRawPointerInst, Unhandled)
CONSTANT_TRANSLATION(UncheckedTrivialBitCastInst, Unhandled)
CONSTANT_TRANSLATION(UncheckedBitwiseCastInst, Unhandled)
CONSTANT_TRANSLATION(UncheckedValueCastInst, Unhandled)
CONSTANT_TRANSLATION(RefToRawPointerInst, Unhandled)
CONSTANT_TRANSLATION(RawPointerToRefInst, Unhandled)
CONSTANT_TRANSLATION(RefToUnownedInst, Unhandled)
CONSTANT_TRANSLATION(UnownedToRefInst, Unhandled)
CONSTANT_TRANSLATION(BridgeObjectToWordInst, Unhandled)
@@ -2605,6 +2619,27 @@ IGNORE_IF_SENDABLE_RESULT_ASSIGN_OTHERWISE(StructExtractInst)
// Custom Handling
//
TranslationSemantics
PartitionOpTranslator::visitRawPointerToRefInst(RawPointerToRefInst *r) {
// If our result is non sendable, perform a look through.
if (isNonSendableType(r->getType()))
return TranslationSemantics::LookThrough;
// Otherwise to be conservative, we need to treat this as a require.
return TranslationSemantics::Require;
}
TranslationSemantics
PartitionOpTranslator::visitRefToRawPointerInst(RefToRawPointerInst *r) {
// If our source ref is non sendable, perform a look through.
if (isNonSendableType(r->getOperand()->getType()))
return TranslationSemantics::LookThrough;
// Otherwise to be conservative, we need to treat the raw pointer as a fresh
// sendable value.
return TranslationSemantics::AssignFresh;
}
TranslationSemantics
PartitionOpTranslator::visitMarkDependenceInst(MarkDependenceInst *mdi) {
translateSILAssign(mdi, mdi->getValue());