averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

ClangImporter: fix C++ memberwise inits to use @lifetime(immortal)

Browse Source 
_unsafeNonEscapableResult no longer dsiables diagnostics at the call site. We
need to use a proper lifetime annotation for that.
This commit is contained in:
Andrew Trick
2025-03-19 11:00:08 -07:00
parent 955d089a90
commit d41c4d4cc9
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/ClangImporter/ImportDecl.cpp
View File

@@ -2036,9 +2036,20 @@ namespace {
}
void markReturnsUnsafeNonescapable(AbstractFunctionDecl *fd) {
fd->getAttrs().add(new (Impl.SwiftContext)
UnsafeNonEscapableResultAttr(/*Implicit=*/true));
fd->getAttrs().add(new (Impl.SwiftContext) UnsafeAttr(/*Implicit=*/true));
unsigned resultIndex = fd->getParameters()->size();
if (fd->hasImplicitSelfDecl()) {
++resultIndex;
}
SmallVector<LifetimeDependenceInfo, 1> lifetimeDependencies;
LifetimeDependenceInfo immortalLifetime(nullptr, nullptr, resultIndex,
/*isImmortal*/ true);
lifetimeDependencies.push_back(immortalLifetime);
Impl.SwiftContext.evaluator.cacheOutput(
LifetimeDependenceInfoRequest{fd},
Impl.SwiftContext.AllocateCopy(lifetimeDependencies));
return;
}
Decl *VisitRecordDecl(const clang::RecordDecl *decl) {
@@ -4060,6 +4071,9 @@ namespace {
CxxEscapability::Unknown) != CxxEscapability::NonEscapable;
};
// FIXME: this uses '0' as the result index. That only works for
// standalone functions with no parameters.
// See markReturnsUnsafeNonescapable() for a general approach.
auto &ASTContext = result->getASTContext();
SmallVector<LifetimeDependenceInfo, 1> lifetimeDependencies;
LifetimeDependenceInfo immortalLifetime(nullptr, nullptr, 0,