averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Dependency Scan] Remove newly-introduced error failure on missing header dependency of a binary module dependency

Browse Source 
Previous behavior had the scanner simply proceed if the header input of a binary Swift module dependency could not be resolved on the filesystem

Resolves rdar://139736789
This commit is contained in:
Artem Chikin
2024-11-13 08:24:27 -08:00
parent e96fc88e58
commit d68b5b2b6e
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/ClangImporter/ClangModuleDependencyScanner.cpp
View File

@@ -552,15 +552,8 @@ bool ClangImporter::getHeaderDependencies(
auto swiftBinaryDeps = targetModuleInfo.getAsSwiftBinaryModule();
if (!swiftBinaryDeps->headerImport.empty()) {
auto clangModuleDependencies = scanHeaderDependencies(swiftBinaryDeps->headerImport);
if (!clangModuleDependencies) {
// FIXME: Route this to a normal diagnostic.
llvm::logAllUnhandledErrors(clangModuleDependencies.takeError(),
llvm::errs());
Impl.SwiftContext.Diags.diagnose(
SourceLoc(), diag::clang_dependency_scan_error,
"failed to scan header dependencies");
if (!clangModuleDependencies)
return true;
}
}
}