averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[region-isolation] Using the print method from the previous commit, ensure that we dump out SentNeverSendable, InOutSendingNotDisconnectedAtExit, AssignNeverSendableIntoSendingResult earlier when we initially detect them.

Browse Source 
This just improves the ability to quickly triage bugs in SendNonSendable. It
used to be this way, but in the process of doing some refactoring, I moved the
logging too late by mistake.
This commit is contained in:
Michael Gottesman
2024-11-18 14:02:27 -08:00
parent d33f819038
commit d94e4c4434
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/SILOptimizer/Mandatory/SendNonSendable.cpp
View File

@@ -2316,10 +2316,8 @@ struct DiagnosticEvaluator final
void handleLocalUseAfterSend(LocalUseAfterSendError error) const {
const auto &partitionOp = *error.op;
Element sentElement = error.sentElement;
Operand *sendingOp = error.sendingOp;
auto &operandState = operandToStateMap.get(sendingOp);
auto &operandState = operandToStateMap.get(error.sendingOp);
// Ignore this if we have a gep like instruction that is returning a
// sendable type and sendingOp was not set with closure
// capture.
@@ -2337,7 +2335,7 @@ struct DiagnosticEvaluator final
REGIONBASEDISOLATION_LOG(error.print(llvm::dbgs(), info->getValueMap()));
sendingOpToRequireInstMultiMap.insert(
sendingOp, RequireInst::forUseAfterSend(partitionOp.getSourceInst()));
error.sendingOp, RequireInst::forUseAfterSend(partitionOp.getSourceInst()));
}
void handleInOutSendingNotInitializedAtExitError(
@@ -2372,6 +2370,11 @@ struct DiagnosticEvaluator final
case PartitionOpError::InOutSendingNotDisconnectedAtExit:
case PartitionOpError::SentNeverSendable:
case PartitionOpError::AssignNeverSendableIntoSendingResult:
// We are going to process these later... but dump so we can see that we
// handled an error here. The rest of the explicit handlers will dump as
// appropriate if they want to emit an error here (some will squelch the
// error).
REGIONBASEDISOLATION_LOG(error.print(llvm::dbgs(), info->getValueMap()));
foundVerbatimErrors.emplace_back(error);
return;
case PartitionOpError::InOutSendingNotInitializedAtExit: {