averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSFix] Adjust IgnoreInvalidFunctionBuilderBody to return true only if errors are emitted

Browse Source
This commit is contained in:
Pavel Yaskevich
2020-08-17 10:54:02 -07:00
parent b2982fa0e5
commit da6bb3657f
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Sema/CSFix.cpp
View File

@@ -1558,9 +1558,11 @@ bool IgnoreInvalidFunctionBuilderBody::diagnose(const Solution &solution,
class PreCheckWalker : public ASTWalker {
DeclContext *DC;
DiagnosticTransaction Transaction;
public:
PreCheckWalker(DeclContext *dc) : DC(dc) {}
PreCheckWalker(DeclContext *dc)
: DC(dc), Transaction(dc->getASTContext().Diags) {}
std::pair<bool, Expr *> walkToExprPre(Expr *E) override {
auto hasError = ConstraintSystem::preCheckExpression(
@@ -1576,12 +1578,16 @@ bool IgnoreInvalidFunctionBuilderBody::diagnose(const Solution &solution,
std::pair<bool, Pattern *> walkToPatternPre(Pattern *P) override {
return std::make_pair(false, P);
}
bool diagnosed() const {
return Transaction.hasDiagnostics();
}
};
PreCheckWalker walker(solution.getDC());
S->walk(walker);
return true;
return walker.diagnosed();
}
IgnoreInvalidFunctionBuilderBody *