averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MoveChecker] Ban exported partial consumption.

Browse Source 
To avoid dialecticization based on compilation mode, ban for
non-resilient modules partial consumption of aggregates which would be
illegal were those modules instead resilient.
This commit is contained in:
Nate Chandler
2024-02-15 16:23:56 -08:00
parent 407fba8375
commit da968dbd58
6 changed files with 369 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
lib/SILOptimizer/Mandatory/MoveOnlyDiagnostics.cpp
View File

@@ -834,12 +834,53 @@ void DiagnosticEmitter::emitCannotPartiallyMutateError(
}();
diagnose(astContext, user, diagnostic, varName);
registerDiagnosticEmitted(address);
auto deinitLoc = error.getNominal().getValueTypeDestructor()->getLoc(
/*SerializedOK=*/false);
auto deinitLoc =
error.getDeinitingNominal().getValueTypeDestructor()->getLoc(
/*SerializedOK=*/false);
if (!deinitLoc)
return;
astContext.Diags.diagnose(deinitLoc, diag::sil_movechecking_deinit_here);
return;
}
case PartialMutationError::Kind::NonfrozenImportedType: {
assert(
astContext.LangOpts.hasFeature(Feature::MoveOnlyPartialConsumption) ||
astContext.LangOpts.hasFeature(
Feature::MoveOnlyPartialReinitialization));
auto &nominal = error.getNonfrozenImportedNominal();
auto diagnostic = [&]() {
switch (kind) {
case PartialMutation::Kind::Consume:
return diag::sil_movechecking_cannot_destructure_imported_nonfrozen;
case PartialMutation::Kind::Reinit:
return diag::sil_movechecking_cannot_partially_reinit_nonfrozen;
}
}();
diagnose(astContext, user, diagnostic, varName,
nominal.getDeclaredInterfaceType(), nominal.getModuleContext());
registerDiagnosticEmitted(address);
return;
}
case PartialMutationError::Kind::NonfrozenUsableFromInlineType: {
assert(
astContext.LangOpts.hasFeature(Feature::MoveOnlyPartialConsumption) ||
astContext.LangOpts.hasFeature(
Feature::MoveOnlyPartialReinitialization));
auto &nominal = error.getNonfrozenUsableFromInlineNominal();
auto diagnostic = [&]() {
switch (kind) {
case PartialMutation::Kind::Consume:
return diag::
sil_movechecking_cannot_destructure_exported_usableFromInline_alwaysEmitIntoClient;
case PartialMutation::Kind::Reinit:
return diag::
sil_movechecking_cannot_partially_reinit_exported_usableFromInline_alwaysEmitIntoClient;
}
}();
diagnose(astContext, user, diagnostic, varName,
nominal.getDeclaredInterfaceType());
registerDiagnosticEmitted(address);
return;
}
}
}