averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #77459 from hborla/preconcurrency-downgrade

Browse Source 
[Concurrency] Fix preconcurrency downgrade behavior for `Sendable` closures and generic requirements.
This commit is contained in:
Holly Borla
2024-11-09 07:18:50 -08:00
committed by GitHub
parent 3c22407b94 7331c5e543
commit dc01137314
12 changed files with 261 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
include/swift/AST/DiagnosticEngine.h
View File

@@ -686,6 +686,30 @@ namespace swift {
InFlightDiagnostic &limitBehaviorUntilSwiftVersion(
DiagnosticBehavior limit, unsigned majorVersion);
/// Limits the diagnostic behavior to \c limit accordingly if
/// preconcurrency applies. Otherwise, the behavior limit only applies
/// prior to the given language mode.
///
/// `@preconcurrency` applied to a nominal declaration or an import
/// statement will limit concurrency diagnostic behavior based on the
/// strict concurrency checking level. Under minimal checking,
/// preconcurrency will suppress the diagnostics. With strict concurrency
/// checking, including when building with the Swift 6 language mode,
/// preconcurrency errors are downgraded to warnings. This allows libraries
/// to stage in concurrency annotations even after their clients have
/// migrated to Swift 6 using `@preconcurrency` alongside the newly added
/// `@Sendable` or `@MainActor` annotations.
InFlightDiagnostic
&limitBehaviorWithPreconcurrency(DiagnosticBehavior limit,
bool preconcurrency,
unsigned languageMode = 6) {
if (preconcurrency) {
return limitBehavior(limit);
}
return limitBehaviorUntilSwiftVersion(limit, languageMode);
}
/// Limit the diagnostic behavior to warning until the specified version.
///
/// This helps stage in fixes for stricter diagnostics as warnings