averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix HTTP2StateMachine benchmark

Browse Source 
The optimizer managed to eliminate this entire benchmark,
resulting in useless 0 second timings.

I made a couple of changes to ensure the optimizer cannot
eliminate the loop:
* The individual checks now actually use the loop parameter
* `identity()` is used to ensure conservatism

While here, I reduced the loop count since these benchmarks seem
to run for a long time.
This commit is contained in:
Tim Kientzle
2023-09-22 17:50:51 -07:00
parent 5a2465efed
commit dc7a3d38cd
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
benchmark/single-source/HTTP2StateMachine.swift
View File

@@ -294,11 +294,11 @@ struct HTTP2StreamStateMachine {
} }
@inline(never) @inline(never)
func testSimpleRequestResponse() -> Bool { func testSimpleRequestResponse(_ n: Int) -> Bool {
var successful = true var successful = true
var server = HTTP2StreamStateMachine(localRole: .server, localWindow: 1<<16, remoteWindow: 1<<16) var server = HTTP2StreamStateMachine(localRole: .server, localWindow: 1<<16, remoteWindow: n)
var client = HTTP2StreamStateMachine(localRole: .client, localWindow: 1<<16, remoteWindow: 1<<16) var client = HTTP2StreamStateMachine(localRole: .client, localWindow: 1<<16, remoteWindow: n)
successful = successful && client.sendHeaders(isEndStreamSet: false) successful = successful && client.sendHeaders(isEndStreamSet: false)
successful = successful && server.receiveHeaders(isEndStreamSet: false) successful = successful && server.receiveHeaders(isEndStreamSet: false)
@@ -329,11 +329,11 @@ func testSimpleRequestResponse() -> Bool {
} }
@inline(never) @inline(never)
func testPushedRequests() -> Bool { func testPushedRequests(_ n: Int) -> Bool {
var successful = true var successful = true
var server = HTTP2StreamStateMachine(sentPushPromiseWithLocalInitialWindowSize: 1<<16) var server = HTTP2StreamStateMachine(sentPushPromiseWithLocalInitialWindowSize: n)
var client = HTTP2StreamStateMachine(receivedPushPromiseWithRemoteInitialWindowSize: 1<<16) var client = HTTP2StreamStateMachine(receivedPushPromiseWithRemoteInitialWindowSize: n)
successful = successful && client.sendWindowUpdate(windowIncrement: 1024) successful = successful && client.sendWindowUpdate(windowIncrement: 1024)
@@ -358,11 +358,11 @@ func testPushedRequests() -> Bool {
} }
@inline(never) @inline(never)
func testPushingRequests() -> Bool { func testPushingRequests(_ n: Int) -> Bool {
var successful = true var successful = true
var server = HTTP2StreamStateMachine(localRole: .server, localWindow: 1<<16, remoteWindow: 1<<16) var server = HTTP2StreamStateMachine(localRole: .server, localWindow: 1<<16, remoteWindow: n)
var client = HTTP2StreamStateMachine(localRole: .client, localWindow: 1<<16, remoteWindow: 1<<16) var client = HTTP2StreamStateMachine(localRole: .client, localWindow: 1<<16, remoteWindow: n)
successful = successful && client.sendHeaders(isEndStreamSet: true) successful = successful && client.sendHeaders(isEndStreamSet: true)
successful = successful && server.receiveHeaders(isEndStreamSet: true) successful = successful && server.receiveHeaders(isEndStreamSet: true)
@@ -381,10 +381,10 @@ func testPushingRequests() -> Bool {
@inline(never) @inline(never)
func run_HTTP2StateMachine(_ n: Int) { func run_HTTP2StateMachine(_ n: Int) {
for _ in 0 ..< 1000000 * n { for i in 0 ..< 100000 * n {
check(testSimpleRequestResponse()) check(testSimpleRequestResponse(identity(i)))
check(testPushedRequests()) check(testPushedRequests(identity(i)))
check(testPushingRequests()) check(testPushingRequests(identity(i)))
} }
} }