averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[docs] FirstPullRequest.md: Adjust for swiftlang

Browse Source
This commit is contained in:
Anthony Latsis
2024-06-26 09:45:42 +03:00
parent 8493312b06
commit dcbc51bfe6
1 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
docs/HowToGuides/FirstPullRequest.md
View File

@@ -125,7 +125,7 @@ Assuming you followed the steps in our [Getting Started guide][], you should now
be able to push your latest changes to GitHub using `git push`.
Next, [create a pull request][] (PR). Usually, if you navigate to
https://github.com/apple/swift right after pushing your change, GitHub will
https://github.com/swiftlang/swift right after pushing your change, GitHub will
show a helpful "Compare & Pull Request" button.
![Compare & Pull Request button in GitHub UI](/docs/GitHubCreatePRScreenshot.png)
@@ -135,25 +135,20 @@ show a helpful "Compare & Pull Request" button.
## Asking for code review
Reviews are automatically requested from collaborators and code owners per the
Reviews are automatically requested from code owners per the
[CODEOWNERS](/.github/CODEOWNERS) file upon opening a non-draft pull request.
If this doesn't happen, @mention and ask a suggested person under **Reviewers**
to review your changes in a comment. If no suggestions are shown either, please
@mention and ask a
[Contributor Experience Workgroup](https://www.swift.org/contributor-experience-workgroup/#membership)
member to sort out review requests for you.
ask @swiftlang/contributor-experience to sort out review requests for you.
You are welcome to invite other people for review as well — say, someone you
had an active discussion with on how to implement your change.
Anyone with a GitHub account can review or comment on changes proposed to
this repository!
Contributors without
[write access](https://swift.org/contributing/#commit-access) are not able to
run the continuous integration (CI) bot, which builds the project and runs
tests. Please ask a code reviewer with write access to invoke the bot for you.
[contributor-experience]: https://forums.swift.org/g/contributor-experience-workgroup
Contributors without [write access][write-access] are not able to run the
continuous integration (CI) bot, which builds the project and runs tests.
Please ask a code reviewer with write access to invoke the bot for you.
## Responding to code review comments
@@ -194,13 +189,13 @@ something in the near future. Please don't feel sad or apologetic!
Awesome! You are welcome to tackle as many [good first issues][good-first-issues]
as it takes for you to gain a desired level of confidence in working with the
codebase. Beyond that, there is an endless supply of [other issues](https://github.com/apple/swift/issues)
codebase. Beyond that, there is an endless supply of [other issues](https://github.com/swiftlang/swift/issues)
waiting for a hero. Don't hesitate to ask for help if you need directions or
get stuck!
Once you've made multiple substantial contributions, you can
[ask for commit access](https://swift.org/contributing/#commit-access),
which will allow you to pick reviewers, trigger the CI bot and merge changes
upon approval.
[ask for commit access][write-access], which will allow you to pick reviewers,
trigger the CI bot and merge changes upon approval.
[good-first-issues]: https://github.com/apple/swift/contribute
[good-first-issues]: https://github.com/swiftlang/swift/contribute
[write-access]: https://swift.org/contributing/#commit-access