averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[caller-analysis] Improve memory usage of FunctionInfo structs by using small data structures instead of large.

Browse Source 
This converts a DenseMap to a SmallMapVector and a SetVector to a
SmallSetVector. Both of these create large malloced data structures by
default. This really makes no sense when there are many functions that don't use
a partial apply or many applies.

Additionally, by changing the DenseMap to a MapVector container, this commit is
eliminating a potential source of non-determinism in the compiler since often
times we are iterating over the DenseMap to produce the results. Today all of
the usages of the DenseMap in this way are safe, but to defensively future proof
this analysis, it makes sense to use a MapVector here.
This commit is contained in:
Michael Gottesman
2018-07-11 18:27:20 -07:00
parent 597698091e
commit dd1a201ed9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/swift/SILOptimizer/Analysis/CallerAnalysis.h
View File

@@ -132,7 +132,8 @@ class CallerAnalysis::FunctionInfo {
friend class CallerAnalysis;
/// A list of all the functions this function calls or partially applies.
llvm::SetVector<SILFunction *> Callees;
llvm::SmallSetVector<SILFunction *, 4> Callees;
/// A list of all the callers this function has.
llvm::SmallSet<SILFunction *, 4> Callers;
@@ -143,7 +144,7 @@ class CallerAnalysis::FunctionInfo {
/// function.
/// This is a little bit off-topic because a partial_apply is not really
/// a "call" of this function.
llvm::DenseMap<SILFunction *, int> PartialAppliers;
llvm::SmallMapVector<SILFunction *, int, 1> PartialAppliers;
public:
/// Returns true if this function has at least one caller.