averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[IDE] Remove extension binding logic from typeCheckContextAt

Browse Source 
Now that we correctly bind extensions after mutating the AST, this
is no longer necessary.
This commit is contained in:
Hamish Knight
2025-08-10 23:49:03 +01:00
parent acf6375d46
commit deecd46e43
5 changed files with 8 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/IDE/CodeCompletion.cpp
View File

@@ -1485,12 +1485,12 @@ void CodeCompletionCallbacksImpl::typeCheckWithLookup(
ASTNode Call = CallExpr::create(
CurDeclContext->getASTContext(), AttrWithCompletion->getTypeExpr(),
AttrWithCompletion->getArgs(), /*implicit=*/true);
typeCheckContextAt(
swift::typeCheckASTNodeAtLoc(
TypeCheckASTNodeAtLocContext::node(CurDeclContext, Call),
CompletionLoc);
}
} else {
typeCheckContextAt(
swift::typeCheckASTNodeAtLoc(
TypeCheckASTNodeAtLocContext::declContext(CurDeclContext),
CompletionLoc);
}
@@ -1551,8 +1551,9 @@ void CodeCompletionCallbacksImpl::postfixCompletion(SourceLoc CompletionLoc,
llvm::SaveAndRestore<TypeCheckCompletionCallback *> CompletionCollector(
Context.CompletionCallback, &Lookup);
typeCheckContextAt(TypeCheckASTNodeAtLocContext::node(CurDeclContext, AE),
CompletionLoc);
swift::typeCheckASTNodeAtLoc(
TypeCheckASTNodeAtLocContext::node(CurDeclContext, AE),
CompletionLoc);
Lookup.collectResults(/*IsLabeledTrailingClosure=*/true, CompletionLoc,
CurDeclContext, CompletionContext);
}
@@ -1711,7 +1712,7 @@ void CodeCompletionCallbacksImpl::doneParsing(SourceFile *SrcFile) {
if (Kind != CompletionKind::TypeSimpleWithDot) {
// Type member completion does not need a type-checked AST.
typeCheckContextAt(
swift::typeCheckASTNodeAtLoc(
TypeCheckASTNodeAtLocContext::declContext(CurDeclContext),
ParsedExpr ? ParsedExpr->getLoc()
: CurDeclContext->getASTContext()